Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the doctest output due to changes in the default grid registration #2284

Merged
merged 3 commits into from
Dec 29, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Dec 29, 2022

Description of proposed changes

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@yvonnefroehlich yvonnefroehlich mentioned this pull request Dec 29, 2022
65 tasks
@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Dec 29, 2022
@seisman seisman added this to the 0.8.0 milestone Dec 29, 2022
@seisman
Copy link
Member Author

seisman commented Dec 29, 2022

Nine inline tests failed in the "Tests" workflow, in which five tests are caused due to the missing IPython package and four tests are caused by the change of the default grid registration from "pixel" to "gridline".

The four outdated inline tests are fixed by commit cff1657.

@seisman seisman marked this pull request as ready for review December 29, 2022 08:40
@seisman seisman added the needs review This PR has higher priority and needs review. label Dec 29, 2022
Copy link
Member

@yvonnefroehlich yvonnefroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The values look now correct for me.

@seisman seisman removed the needs review This PR has higher priority and needs review. label Dec 29, 2022
@seisman seisman merged commit f019bb0 into main Dec 29, 2022
@seisman seisman deleted the update-doctests branch December 29, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants