-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog entry for v0.4.0 #1341
Conversation
For updating the citation information, the AUTHORSHIP.md file says that "The order of authors will be defined by the number of commits to the repository (git shortlog -sne). The order can also be changed on a case-by-case basis." How do I know whether any of the current order reflects a case-by-case basis or whether I should update based on |
See previous discussion at #1047 (comment). Will leave it up to you to take a first stab at the order :) Just to clarify, that line refers to the Zenodo citation order. The release note authors order should go strictly by |
OK, I guess I wasn't paying good attention for that release :) Thanks for the note. |
I don't think it's an issue. The badges are working on the pypi site (https://pypi.org/project/pygmt/) and we don't make changes to badges since v0.3.1. |
Co-authored-by: Yao Jiayuan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my side everything looks fine. All open points are considered. Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not check the authors, but all the other looks great.
Should I wait for Wei Ji to approve as well or is OK to move forward with the comments addressed and the three approvals? |
Perhaps it would better to wait for his approval too, since it does not matter to release v0.4 a few hours earlier or later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one suggestion, otherwise all good!
* Add changelog entry to changes.md * Update release highlights * Reorganize contributor list * Update citation * Update version_switch.js * Update documentation link Co-authored-by: Wei Ji <[email protected]> Co-authored-by: Dongdong Tian <[email protected]> Co-authored-by: Yao Jiayuan <[email protected]>
Description of proposed changes
This PR is a draft changelog entry for v0.4.0.
Preview: https://pygmt-git-changelog-release-gmt.vercel.app/changes.html#changelog
Previous release at #1047
Changelog made by following the instructions at https://github.com/GenericMappingTools/pygmt/blob/master/doc/maintenance.md#updating-the-changelog
To do:
Relates to #1333
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version