Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Z alias in histogram #1274

Merged
merged 1 commit into from
May 14, 2021
Merged

Rename Z alias in histogram #1274

merged 1 commit into from
May 14, 2021

Conversation

michaelgrund
Copy link
Member

Description of proposed changes

As discussed in #1272 the alias for Z should be renamed since type is already used as Python built-in method.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

As discussed in #1272 the alias for Z should be renamed since ``type`` is already used as Python built-in method.
@michaelgrund michaelgrund changed the title Rename Z alias in histogram WIP: Rename Z alias in histogram May 14, 2021
@michaelgrund michaelgrund marked this pull request as draft May 14, 2021 08:31
@michaelgrund michaelgrund added this to the 0.4.0 milestone May 14, 2021
@michaelgrund michaelgrund added the enhancement Improving an existing feature label May 14, 2021
@michaelgrund michaelgrund changed the title WIP: Rename Z alias in histogram Rename Z alias in histogram May 14, 2021
@michaelgrund michaelgrund marked this pull request as ready for review May 14, 2021 08:47
Copy link
Contributor

@willschlitzer willschlitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @seisman and @michaelgrund. I think this is a smart change.

Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, feel free to merge this in directly.

@michaelgrund michaelgrund merged commit 3644860 into master May 14, 2021
@michaelgrund michaelgrund deleted the rename-z-histogram branch May 14, 2021 19:47
@weiji14 weiji14 added the skip-changelog Skip adding Pull Request to changelog label May 15, 2021
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving an existing feature skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants