Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap grdlandmask #1273

Merged
merged 33 commits into from
May 26, 2021
Merged

Wrap grdlandmask #1273

merged 33 commits into from
May 26, 2021

Conversation

willschlitzer
Copy link
Contributor

@willschlitzer willschlitzer commented May 14, 2021

This pull request wraps the grdlandmask module.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added the feature Brand new feature label May 14, 2021
@willschlitzer willschlitzer added this to the 0.4.0 milestone May 14, 2021
@willschlitzer willschlitzer self-assigned this May 14, 2021
@willschlitzer
Copy link
Contributor Author

I'm running into a newfound problem with this module. When I run:

import pygmt
new_grid = pygmt.grdlandmask(increment=1, region = [-5, 5, -5, 5])

I receive: TypeError: 'module' object is not callable

I've done the typical trouble shooting (confirmed I'm in the correct conda environment, have the appropriate git branch activated, checked the import statements and function to make sure it's in line with other modules, and, of course, shut it down and started it up again) so I'm not sure why I'm getting this issue. @weiji14 @seisman any ideas?

@willschlitzer willschlitzer changed the title WIP: Wrap grdlandmask Wrap grdlandmask May 18, 2021
@willschlitzer willschlitzer marked this pull request as ready for review May 18, 2021 08:04
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label May 24, 2021
@seisman
Copy link
Member

seisman commented May 24, 2021

@willschlitzer Feel free to merge this PR after all tests pass.

@willschlitzer willschlitzer requested a review from weiji14 May 26, 2021 05:40
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some final suggestions. Feel free to merge after the tests pass.

@willschlitzer willschlitzer merged commit 46f739a into master May 26, 2021
@willschlitzer willschlitzer deleted the wrap-grdlandmask branch May 26, 2021 10:18
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
* Add grdlandmask.py and test_grdlandmask.py

Co-authored-by: Wei Ji <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Yao Jiayuan <[email protected]>
Co-authored-by: Meghan Jones <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Brand new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants