-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap grdlandmask #1273
Wrap grdlandmask #1273
Conversation
I'm running into a newfound problem with this module. When I run:
I receive: I've done the typical trouble shooting (confirmed I'm in the correct conda environment, have the appropriate git branch activated, checked the import statements and function to make sure it's in line with other modules, and, of course, shut it down and started it up again) so I'm not sure why I'm getting this issue. @weiji14 @seisman any ideas? |
Co-authored-by: Wei Ji <[email protected]>
Co-authored-by: Meghan Jones <[email protected]>
@willschlitzer Feel free to merge this PR after all tests pass. |
Co-authored-by: Wei Ji <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some final suggestions. Feel free to merge after the tests pass.
Co-authored-by: Wei Ji <[email protected]>
* Add grdlandmask.py and test_grdlandmask.py Co-authored-by: Wei Ji <[email protected]> Co-authored-by: Dongdong Tian <[email protected]> Co-authored-by: Yao Jiayuan <[email protected]> Co-authored-by: Meghan Jones <[email protected]>
This pull request wraps the
grdlandmask
module.Fixes #
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version