-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog entry for v0.3.1 release #1047
Merged
Merged
Changes from 5 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
a38d9d3
Update README.rst for v0.3.1 release
willschlitzer 9d058a4
Update version_switch.js for v0.3.1 release
willschlitzer a783324
Add changelog entry to changes.md
willschlitzer 6763056
Minor change log updates
willschlitzer 46d58f3
Update doc/changes.md
willschlitzer 4a9ebef
Update README.rst
willschlitzer 001ab97
add Alicia Ngoc Diep Ha to contributors
willschlitzer 956a8dc
Merge remote-tracking branch 'origin/v0.3.1-release' into v0.3.1-release
willschlitzer 88a0f8a
add Tawanda Moyo to contributors
willschlitzer 27c5f50
Apply suggestions from code review
willschlitzer ccca7e6
Merge branch 'master' into v0.3.1-release
willschlitzer 8f10941
Update release highlights
willschlitzer e377ead
change wording
willschlitzer d31a4ea
Apply suggestions from code review
willschlitzer 444ef30
Update v0.3.1 highlights
willschlitzer c1ce366
Update doc/changes.md
willschlitzer 85f8553
Update v0.3.1 highlights wording
willschlitzer 80f6ee7
Merge remote-tracking branch 'origin/v0.3.1-release' into v0.3.1-release
willschlitzer 5228afa
Update doc/changes.md
willschlitzer 958ce13
reorganize contributor list
willschlitzer 7f7f968
Merge remote-tracking branch 'origin/v0.3.1-release' into v0.3.1-release
willschlitzer 8fef314
reorganize author list
willschlitzer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had based this off number of commits yesterday; I'll put
Toney, Liam and Schlitzer, William and Yao, Jiayuan and Grund, Michael and
In the v0.3.0 release we put @liamtoney up higher because of his ROSES video, which may not count towards his commits but has significantly enhanced the project. Ping @GenericMappingTools/python for input, but I think he should remain where he is in the order because he is spearheading the SciPy session.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, on a first order, we sort things by the number of commits. But pay attention to the next sentence "The order can also be changed on a case-by-case basis". The idea is that contributions are not just about commits but also the other things people do. For example, Liam put a lot of work into the ROSES tutorial (the video on the front page) and Meghan has done lots of things behind the scenes such as funding applications and setting up accounts.
I don't want to get too fired up about name ordering, but it's really up to you all to negotiate what you think is best. Just stating that there are other factors to consider :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes pushed in 8fef314
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's reasonable. I also think Liam and Meghan have conducted a lot of work beyond just code commit. Good to know we can pay attention to those contributions a lot. Actually, I begin to know PyGMT from his ROSES tutorial. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me too! Thanks Liam!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everythin fine for me 😉.