-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a gallery example for a double y-axes graph #1019
Conversation
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Michael Grund <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
|
Also need to add the new category to Line 74 in b2b3d1f
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good to me.
Ping @meghanrjones @michaelgrund for final comments and approvals.
Please note that this example is added to a new category "Base maps". Do you think it's good? Also ping @willschlitzer @weiji14.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except the provided minor suggestions this PR looks good to me. The new category is suitable in my eyes. Good work!
Co-authored-by: Michael Grund <[email protected]>
Co-authored-by: Michael Grund <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I just have one small recommendation to avoid confusion about stating that two basemaps should be plotted and then plotting three basemaps (common x, y1, y2).
Co-authored-by: Meghan Jones <[email protected]>
…1019) Also add a new category "Base maps". Co-authored-by: Dongdong Tian <[email protected]> Co-authored-by: Michael Grund <[email protected]> Co-authored-by: Meghan Jones <[email protected]>
Description of proposed changes
This gallery plots two base maps with the same X-axis but different Y-axes, while it also plots data points and lines for the two corresponding Y values, separately.
Fixes #1009
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version