Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the docstring of the pygmt package #1016

Merged
merged 13 commits into from
Mar 10, 2021
Merged

Conversation

michaelgrund
Copy link
Member

@michaelgrund michaelgrund commented Mar 7, 2021

Based on #1012, here's a first suggestion (partly influced by the pandas docstring) for improving the docstring which is displayed when running import pygmt followed by help(pygmt). Open for discussions, improvements and other ideas.

Description of proposed changes

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

Based on #1012, here's a first suggestion for improving the docstring which is displayed when running ``import pygmt``  followed by ``help(pygmt)``.
@michaelgrund michaelgrund added the documentation Improvements or additions to documentation label Mar 7, 2021
@michaelgrund michaelgrund added this to the 0.3.1 milestone Mar 7, 2021
@michaelgrund michaelgrund linked an issue Mar 7, 2021 that may be closed by this pull request
@michaelgrund michaelgrund marked this pull request as draft March 7, 2021 17:52
@michaelgrund
Copy link
Member Author

/format

@michaelgrund
Copy link
Member Author

Do we need the pylint: disable=missing-docstring in the first line ?

@michaelgrund
Copy link
Member Author

/format

@michaelgrund michaelgrund requested a review from a team March 7, 2021 19:19
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
@seisman seisman marked this pull request as ready for review March 9, 2021 16:08
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@core-man
Copy link
Member

core-man commented Mar 9, 2021

Great~ I think it's good.

Copy link
Member

@maxrjones maxrjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just one tiny comment

Co-authored-by: Meghan Jones <[email protected]>
@seisman seisman merged commit 88d5b0e into master Mar 10, 2021
@seisman seisman deleted the improve-pygmt-docstring branch March 10, 2021 04:28
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Yao Jiayuan <[email protected]>
Co-authored-by: Meghan Jones <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the docstring of the pygmt package
5 participants