Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the expected result in test/api/apiputvector.sh #8615

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented Nov 11, 2024

The test test/api/apiputvector.sh checks the output of the test program https://github.com/GenericMappingTools/gmt/blob/master/src/testapi_putvector.c.

As you can see in the C file, the first column the program passes is 134.9 and 202. So we also expect to see 134.9 and 202 as the first column in the output. However, the answer.txt file holds the incorrect answer due to a GMT bug.

The bug was fixed recently in #8600. That's why the test starts to fail recently. This PR fixes the answer.txt file and now the test passes again.

@seisman seisman added the maintenance Boring but important stuff for the core devs label Nov 11, 2024
@seisman seisman added this to the 6.6.0 milestone Nov 11, 2024
@seisman seisman requested a review from joa-quim November 11, 2024 13:25
@seisman seisman merged commit 548e6ed into master Nov 11, 2024
2 of 5 checks passed
@seisman seisman deleted the fix/apiputvector.sh branch November 11, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants