Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Covert growth link to be on log scale #357

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Covert growth link to be on log scale #357

merged 1 commit into from
Jun 18, 2024

Conversation

gowerc
Copy link
Collaborator

@gowerc gowerc commented Jun 17, 2024

Closes #355

@gowerc gowerc requested a review from gravesti June 17, 2024 17:43
Copy link
Contributor

badge

Code Coverage Summary

Filename                           Stmts    Miss  Cover    Missing
-------------------------------  -------  ------  -------  --------------------------------
R/brier_score.R                      166       0  100.00%
R/DataJoint.R                         76       2  97.37%   264, 270
R/DataLongitudinal.R                 119       1  99.16%   244
R/DataSubject.R                       85       1  98.82%   142
R/DataSurvival.R                      98       0  100.00%
R/defaults.R                          10       6  40.00%   18-57, 84
R/generics.R                          31       4  87.10%   51, 395, 414, 449
R/Grid.R                              27       1  96.30%   173
R/GridEven.R                          32       0  100.00%
R/GridEvent.R                         22       0  100.00%
R/GridFixed.R                         30       0  100.00%
R/GridGrouped.R                       52       0  100.00%
R/GridManual.R                        23       3  86.96%   78-80
R/GridObserved.R                      20       0  100.00%
R/GridPopulation.R                    31       4  87.10%   61, 69-71
R/GridPrediction.R                    36       6  83.33%   83, 91-95
R/JointModel.R                       123       8  93.50%   141-143, 193, 197, 239, 285, 291
R/JointModelSamples.R                 59       0  100.00%
R/link_generics.R                     13       3  76.92%   59, 76, 91
R/Link.R                              62       4  93.55%   200-203
R/LinkComponent.R                     19       3  84.21%   88, 120-121
R/LongitudinalGSF.R                   82       0  100.00%
R/LongitudinalModel.R                 19       0  100.00%
R/LongitudinalQuantities.R            71       0  100.00%
R/LongitudinalRandomSlope.R           41       5  87.80%   93-97
R/LongitudinalSteinFojo.R             75       5  93.33%   143-147
R/Parameter.R                         14       0  100.00%
R/ParameterList.R                     42       1  97.62%   184
R/Prior.R                            236       8  96.61%   481, 577, 589-607
R/Promise.R                           25       0  100.00%
R/Quantities.R                        60       0  100.00%
R/QuantityGeneratorPopulation.R       22       0  100.00%
R/QuantityGeneratorPrediction.R       48       0  100.00%
R/QuantityGeneratorSubject.R          19       0  100.00%
R/settings.R                          12      12  0.00%    55-69
R/SimGroup.R                           5       0  100.00%
R/SimJointData.R                      72       1  98.61%   103
R/SimLongitudinal.R                    5       2  60.00%   22, 40
R/SimLongitudinalGSF.R                53       0  100.00%
R/SimLongitudinalRandomSlope.R        42       0  100.00%
R/SimLongitudinalSteinFojo.R          50       0  100.00%
R/SimSurvival.R                      104       0  100.00%
R/StanModel.R                         15       0  100.00%
R/StanModule.R                       176       6  96.59%   192-193, 235, 246, 383, 411
R/SurvivalExponential.R               10       0  100.00%
R/SurvivalLoglogistic.R               11       0  100.00%
R/SurvivalModel.R                     19       0  100.00%
R/SurvivalQuantities.R               170       1  99.41%   125
R/SurvivalWeibullPH.R                 11       0  100.00%
R/utilities.R                        143       1  99.30%   13
R/zzz.R                               28      25  10.71%   3, 8-12, 14-35, 47
TOTAL                               2814     113  95.98%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: d679512

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

Unit Tests Summary

  1 files  140 suites   7m 47s ⏱️
131 tests 104 ✅ 27 💤 0 ❌
934 runs  902 ✅ 32 💤 0 ❌

Results for commit d679512.

Copy link
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
compile 💔 $5.01$ $+9.94$ $0$ $0$ $0$ $0$
model_multi_chain 💔 $35.68$ $+1.40$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
Grid 💔 $40.23$ $+2.30$ Grid_objects_work_with_QuantityGenerator_and_QuantityCollapser
GridPrediction 💔 $157.68$ $+2.49$ GridPrediction_works_as_expected_for_Survival_models
LongitudinalQuantiles 💔 $43.53$ $+1.85$ Test_that_LongitudinalQuantities_works_as_expected
LongitudinalRandomSlope 💚 $1.40$ $-1.33$ Print_method_for_LongitudinalRandomSlope_works_as_expected
SurvivalExponential 💔 $27.40$ $+2.13$ SurvivalExponential_can_recover_true_parameter_including_covariates_
SurvivalLoglogistic 💚 $3.55$ $-1.65$ sim_os_loglogistic_is_consistant_with_flexsurv
SurvivalQuantities 💔 $9.68$ $+8.76$ SurvivalQuantities_and_autoplot.SurvivalQuantities_works_as_expected
SurvivalWeibullPH 💔 $7.33$ $+23.06$ Print_method_for_SurvivalWeibullPH_works_as_expected
brierScore 💚 $33.48$ $-28.29$ brierScore_SurvivalQuantities_returns_same_results_as_survreg
compile 💔 $5.01$ $+9.94$ compileStanModel_doesn_t_error_if_the_directory_doesn_t_exist
model_multi_chain 💔 $35.68$ $+1.40$ Can_recover_known_distribution_parameters_from_random_slope_model_when_using_multiple_chains

Results for commit f0b7cf3

♻️ This comment has been updated with latest results.

@gowerc gowerc merged commit 1d68e2f into main Jun 18, 2024
23 checks passed
@gowerc gowerc deleted the 355-log-growth branch June 18, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SF and GSF should use log growth
2 participants