Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More examples of AIC / BIC / loo #262

Merged
merged 22 commits into from
Feb 22, 2024
Merged

More examples of AIC / BIC / loo #262

merged 22 commits into from
Feb 22, 2024

Conversation

gowerc
Copy link
Collaborator

@gowerc gowerc commented Feb 21, 2024

This PR adds more examples of using AIC / BIC / LOO as well as an log-logistic example.

I don't think there are any meaningful changes to the package here so more just an FYI.

Can't be merged until #259 has been merged as its built on top of that branch.

Copy link
Contributor

github-actions bot commented Feb 21, 2024

badge

Code Coverage Summary

Filename                       Stmts    Miss  Cover    Missing
---------------------------  -------  ------  -------  --------------------------------
R/brier_score.R                  166       0  100.00%
R/DataJoint.R                     76       2  97.37%   264, 270
R/DataLongitudinal.R             119       1  99.16%   245
R/DataSubject.R                   69       1  98.55%   124
R/DataSurvival.R                  74       1  98.65%   146
R/defaults.R                      10       6  40.00%   18-57, 84
R/generics.R                      19       1  94.74%   49
R/JointModel.R                   122       8  93.44%   142-144, 194, 198, 240, 286, 292
R/JointModelSamples.R             54       0  100.00%
R/Link.R                          55       4  92.73%   159-162
R/LinkComponent.R                 47       5  89.36%   100, 118, 132-149
R/LongitudinalGSF.R               64       0  100.00%
R/LongitudinalModel.R             35      12  65.71%   68-83
R/LongitudinalQuantities.R        85       8  90.59%   100-107
R/LongitudinalRandomSlope.R       27       0  100.00%
R/Parameter.R                     14       0  100.00%
R/ParameterList.R                 42       1  97.62%   184
R/Prior.R                        236       8  96.61%   480, 576, 588-606
R/Quantities.R                   105       0  100.00%
R/settings.R                      11      11  0.00%    40-53
R/simulations_gsf.R               41       0  100.00%
R/simulations_os.R                11       5  54.55%   35-39
R/simulations_rs.R                21       0  100.00%
R/simulations.R                   99       1  98.99%   122
R/StanModel.R                     15       0  100.00%
R/StanModule.R                   177       6  96.61%   199-200, 242, 253, 388, 416
R/SurvivalExponential.R           10       0  100.00%
R/SurvivalLoglogistic.R           11       0  100.00%
R/SurvivalModel.R                 19       0  100.00%
R/SurvivalQuantities.R           151       6  96.03%   173-178
R/SurvivalWeibullPH.R             11       0  100.00%
R/utilities.R                    145       1  99.31%   13
R/zzz.R                            2       2  0.00%    3-12
TOTAL                           2143      90  95.80%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 778f254

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

Unit Tests Summary

  1 files   34 suites   5m 49s ⏱️
102 tests  78 ✅ 24 💤 0 ❌
783 runs  759 ✅ 24 💤 0 ❌

Results for commit b84b0b0.

Copy link
Contributor

github-actions bot commented Feb 22, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
LongitudinalGSF 💚 $63.10$ $-2.75$ $0$ $0$ $0$ $0$
model_random_slope_2chain 💚 $39.48$ $-1.72$ $0$ $0$ $0$ $0$
stan_functions 💚 $49.02$ $-1.03$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
LongitudinalGSF 💚 $31.95$ $-2.11$ Can_recover_known_distributional_parameters_from_a_full_GSF_joint_model
LongitudinalQuantiles 💚 $38.26$ $-1.17$ Test_that_LongitudinalQuantities_works_as_expected
model_random_slope_2chain 💚 $39.48$ $-1.72$ Can_recover_known_distribution_parameters_from_random_slope_model_when_using_multiple_chains

Results for commit 3ad596c

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good, thanks Craig

@gowerc gowerc merged commit dcce0f8 into main Feb 22, 2024
19 checks passed
@gowerc gowerc deleted the aic-bic branch February 22, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants