Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/print quantities #237

Merged
merged 9 commits into from
Oct 20, 2023
Merged

Feature/print quantities #237

merged 9 commits into from
Oct 20, 2023

Conversation

gowerc
Copy link
Collaborator

@gowerc gowerc commented Oct 19, 2023

Closes #197

Implements the final missing print methods for:

  • Quantities
  • LongitudinalQuantities
  • SurvivalQuantities
  • JointModelSamples
  • StanModule

Apologies after looking through the documentation I realised I had used the legacy function expect_snapshot_output in a couple of places which I had to change to expect_snapshot but this had the side effect of changing some of the existing stored print snapshots as expect_snapshot also stores the code used to generate them. As far as I can tell though none of the actual output content has changed.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023

Unit Tests Summary

    1 files    33 suites   8m 6s ⏱️
  88 tests   64 ✔️ 24 💤 0
301 runs  277 ✔️ 24 💤 0

Results for commit a484f1a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023

badge

Code Coverage Summary

Filename                       Stmts    Miss  Cover    Missing
---------------------------  -------  ------  -------  ----------------------
R/DataJoint.R                     76       2  97.37%   264, 270
R/DataLongitudinal.R             119       1  99.16%   245
R/DataSubject.R                   69       1  98.55%   123
R/DataSurvival.R                  74       1  98.65%   145
R/defaults.R                      13       7  46.15%   27, 45-84, 111
R/generics.R                      15       1  93.33%   69
R/JointModel.R                    91       8  91.21%   113-125, 204, 210, 216
R/JointModelSamples.R             54       0  100.00%
R/Link.R                          18       0  100.00%
R/LinkGSF.R                       69      13  81.16%   116-128
R/LinkNone.R                       5       1  80.00%   36
R/LinkRandomSlope.R               11       0  100.00%
R/LongitudinalGSF.R               24       0  100.00%
R/LongitudinalModel.R             17       0  100.00%
R/LongitudinalQuantities.R        85       8  90.59%   100-107
R/LongitudinalRandomSlope.R       22       0  100.00%
R/Parameter.R                     14       0  100.00%
R/ParameterList.R                 37       1  97.30%   175
R/Prior.R                        117       0  100.00%
R/Quantities.R                   105       0  100.00%
R/simulations_gsf.R               43       0  100.00%
R/simulations_os.R                11       5  54.55%   35-39
R/simulations_rs.R                21       0  100.00%
R/simulations.R                   99       1  98.99%   122
R/StanModel.R                     14       0  100.00%
R/StanModule.R                   158       4  97.47%   197-198, 240, 251
R/SurvivalExponential.R           10       0  100.00%
R/SurvivalLoglogistic.R           11       0  100.00%
R/SurvivalModel.R                 19       0  100.00%
R/SurvivalQuantities.R           119       6  94.96%   173-178
R/SurvivalWeibullPH.R             11       0  100.00%
R/utilities.R                    145       1  99.31%   13
R/zzz.R                           11      11  0.00%    4-29
TOTAL                           1707      72  95.78%

Diff against main

Filename                      Stmts    Miss  Cover
--------------------------  -------  ------  --------
R/JointModelSamples.R           +31       0  +100.00%
R/LongitudinalQuantities.R      +14       0  +1.86%
R/Quantities.R                  +16       0  +100.00%
R/StanModule.R                  +13      -1  +0.92%
R/SurvivalQuantities.R          +16       0  +0.78%
TOTAL                           +90      -1  +0.30%

Results for commit: a484f1a

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

tests/testthat/test-SurvivalQuantities.R Outdated Show resolved Hide resolved
@gowerc gowerc merged commit 019d4ee into main Oct 20, 2023
@gowerc gowerc deleted the feature/print-quantities branch October 20, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Print Methods
2 participants