-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable shibboleth for non KIT ilias #98
Conversation
75cb4fc
to
959fa8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This looks like a relatively straight-forward change, but you reformatted quite a few files to a smaller width. Can you please revert those changes? They make the text a bit harder, and the diff much harder to read :) I guess your editor just did not pick up on the 110 defined in the pyproject.toml file.
51496b6
to
f5c4e82
Compare
Hey, it would be cool if you could resolve the comments you have addressed in the UI (and maybe address the remaining two) when you have time :) That makes it a bit easier to see if action from our side is required and prevents us three deadlocking :P |
Should be all done now, thanks. Be sure to tell me if there's anything else in here that I need to address. |
I have no idea why, but the 302 redirect does not work for KIT. It gets rejected with a "message does not meet security requirements", but no further mention why. Opening the same URL in a fresh browser window works. Shib really doesn't like the PFERD request though, even when it looks virtually identical. I have no real idea why, but I can therefore not merge this. The old POST workflow works for KIT, so maybe just fall back to that one in the KIT case and let the rest fend for themselves. |
Co-authored-by: Mr-Pine <[email protected]>
Co-authored-by: MrPine <[email protected]>
Co-authored-by: I-Al-Istannen <[email protected]>
Co-authored-by: I-Al-Istannen <[email protected]>
Co-authored-by: I-Al-Istannen <[email protected]>
The base URL needs a trailing "/", so the part after the first "/" won't be ignored.
84563c9
to
744efb3
Compare
744efb3
to
74a7339
Compare
@PinieP does this still work on your instance? Please make very sure it is not reusing any cookies. Ideally you would download a folder into a fresh directory in |
74a7339
to
0cdb59c
Compare
Still works for me. Thanks! |
0cdb59c
to
ec80e7b
Compare
Thanks :) |
This pull request adds support for shibboleth login to (non KIT) ilias-web crawler.