Optimize ML-DSA Implementation #232
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
…Specification.cry We also edit ML_DSA.cry to point to the optimized file. We avoid importing private functions or properties as these have already been tested. Looking forward, we will optimize some of these functions and will define equivalence properties.
mariosge
force-pushed
the
205-ml-dsa-optimize-implementation
branch
from
e45267a to
60b2c83
Compare
In particular, we optimize `IntegerToBits`, `BitsToInteger`, `IntegerToBytes`, `BitsToBytes` and `BytesToBits`. We also add equivalence properties. The updated functions are around 10x faster.
The functions we optimize are: `SimpleBitPack`, `BitPack`, `SimpleBitUnpack` and `BitUnpack`. These functions are now 10x faster than in the specs. We also implement and check equivalence properties.
marsella
requested changes
Jan 30, 2025
There was a problem hiding this comment.
Thank you, this looks great! I'd be very interested to see what kind of runtime improvement we get on the top-level functions (_internal). It probably won't be 10x because NTT and other operations are slow right now, but that's the big one we're interested in.
I have a couple docs requests and one bug.
Primitive/Asymmetric/Signature/ML_DSA/OptimizedSpecification.cry
Outdated
Show resolved
Hide resolved
These definitions are copied and pasted directly from the Specification.cry file. Only tiny edits in the some type parameters are made and are explicitly mentioned in the doc comments. The edited functions are: `KeyGen_internal`, `pkEncode`, `pkDecode`, `skEncode`, `skDecode`, `sigEncode`, `sigDecode`, `w1Encode`, `SampleInBall`, `ExpandA`, `ExpandS` and `ExpandMask`
…rove in a reasonable amount of time or if checking is better
mariosge
force-pushed
the
205-ml-dsa-optimize-implementation
branch
from
5949fb4 to
fd3c350
Compare
marsella
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #205