Fix hexdump_iter for actual file objects, like those used by phd #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachriggle
force-pushed
the
pwntools-3.3.3-phd-regression
branch
from
c6433be to
1155573
Compare
|
@idolf ping |
| total = fd.tell() | ||
| total = fd.tell() - cur | ||
|
|
||
| # Restore the file offset, and |
There was a problem hiding this comment.
No "and", just a dangling lost thought in a comment.
This commit is cherry-picked from dev (f46112e), which has the same dangling comment -- but also has tests which pass.
|
head -c 128 /bin/sh | phd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a regression introduced somewhere between 3.3.1 and 3.3.3 from earlier this week.