Remove tuple parameters unpacking due to PEP-3113 #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase this on top of Other than that, looks good, thanks! |
|
Is the branch name the reason why tests got broken? I'm just curious. I think it has something to do with #1113 |
|
No, the tests were broken because Don't just merge a specific pull request, merge the |
|
The Arusekk/pwntools@closer-to-3...Gallopsled:dev The problem is that the tests failure is still unsolved, I will comment on it directly in #1112 or open another pull request solving that problem. |
As a step towards python3 compatibility, removed tuple parameters in :mod:`pwnlib.term.term`. They are now replaced with * unpacking. See https://www.python.org/dev/peps/pep-3113/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a step towards python3 compatibility, removed tuple parameters
in
pwnlib.term.term. They are now replaced with * unpacking.See https://www.python.org/dev/peps/pep-3113/