Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The shellcraft bash completition does not work #767

Closed
TethysSvensson opened this issue Oct 13, 2016 · 5 comments
Closed

The shellcraft bash completition does not work #767

TethysSvensson opened this issue Oct 13, 2016 · 5 comments
Milestone

Comments

@TethysSvensson
Copy link
Contributor

Typing shellcraft and pressing tab results in this:

dev:~/git/pwntools> shellcraft 
...         checksec    cyclic      elfdiff     errno       hex         pwn         scramble    unhex       usage:      
asm         constgrep   disasm      elfpatch    [-h]        phd         pwnstrip    shellcraft  update
@zachriggle
Copy link
Member

The only time it was ever modified after its addition was 66e41bd. I've never used it, I'm unsure if it works. It looks like the bash completion now requires use of pwn shellcraft <tab>. Feel free to make changes as you see fit to resolve it.

@zachriggle
Copy link
Member

For what it's worth, we should probably be using argcomplete for completion scripts anyway.

@zachriggle
Copy link
Member

It looks like genzshcomp also exists for zsh users.

@bstub
Copy link
Contributor

bstub commented Oct 16, 2016

What about using the cmd module?

https://wiki.python.org/moin/CmdModule

(follow-up: after closer inspection, the auto-complete functionality seems to only work when the cli have been launched)

@zachriggle
Copy link
Member

The cmd module is for implementing a command-line, with completion -- not for generating bash- or zsh-compatible completion files.

zachriggle added a commit to zachriggle/pwntools that referenced this issue Oct 17, 2016
@zachriggle zachriggle added this to the 3.2.0 milestone Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants