Notify that screenshots were taken when using TakeScreenhot in order to associate a screenshot with an action

[stickleprojects]

Hi
I'm trying to track the screenshot filenames to the appropriate action and wanted your thoughts on how this would be implemented.

Ive tried to locate examples of decorators communicating with each other and cant see any- and am unsure if this would create a hidden dependency because screenshot actor would have to "wrap" a reporting actor, in order for the reporting actor to get "notified" of the screenshot actions being taken.
I've used component design pattern to handle this in games but I dont think it follows the decorator pattern used throughout this app.

thoughts?

[Galad]

Hello,

Thanks for you interest in this project :)
I don't think those features should be coupled because the way they are designed creates a pipeline for the actions execution, meaning we could enable, disable or order them any way we want.

So what I can propose is to add an optional IObserver<T> to the TakeScreenshot extension method, that would notifiy when a screenshot has been taken.

var observer =    new ConsoleObserver(); //an observer that writes in the console
var actor = new Actor("John")
                  .WithReporting(observer)
                  .TakeScreenshots(@"C:\Enablon\Screenshots", screenshotName, observer)

It would allow the notifications to end up in the same observer, meaning you would have the following output in the log.

Starting add an item
--- Starting Enter the value "milk"
--- Screenshot 1.jpg was taken
--- Ending Enter the value "milk"
--- Starting Click on some button
--- Screenshot 2.jpg was taken
--- Ending Click on some button
Ending add an item

Would that solution solve your issue ?

[stickleprojects]

Looks great! Thanks. Shall I go ahead and implement? On 6 Dec 2017 16:28, "Lucas Loegel" <[email protected]> wrote: Closed #2 <#2>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKjfL09OeE73IJVV610NNQneZZqkX26tks5s9sCsgaJpZM4Qaqwf> .

[Galad]

Sure go ahead!