Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump codecov/codecov-action from 4.3.0 to 4.3.1 in the actions group #99

Merged
merged 2 commits into from
May 7, 2024
Merged

build(deps): bump codecov/codecov-action from 4.3.0 to 4.3.1 in the actions group #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26782d4
build(deps): bump codecov/codecov-action in the actions group
dependabot[bot] May 6, 2024
8b7d74e
fix: test
nstarman May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,4 @@ jobs:
--cov-report=term --durations=20 --arraydiff -m"not slow"

- name: Upload coverage report
uses: codecov/[email protected].0
uses: codecov/[email protected].1
13 changes: 6 additions & 7 deletions tests/test_d3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,14 +417,13 @@ def test_spherical_to_cylindrical_astropy(self, vector, apyvector):
)

apycyl = apyvector.represent_as(apyc.CylindricalRepresentation)
assert np.allclose(convert(cyl.rho, APYQuantity), apycyl.rho)
assert np.allclose(convert(cyl.z, APYQuantity), apycyl.z)
# There's a 'bug' in Astropy where rho can be negative.
with pytest.raises(AssertionError):
assert convert(cyl.rho[-1], APYQuantity) == apycyl.rho[-1]
assert np.allclose(convert(cyl.rho, APYQuantity), np.abs(apycyl.rho))

assert np.allclose(convert(cyl.phi[:-1], APYQuantity), apycyl.phi[:-1])
# There's a 'bug' in Astropy where at the origin phi is always 90, or at
# least doesn't keep its value.
with pytest.raises(AssertionError): # TODO: Fix this
assert np.allclose(convert(cyl.phi[-1], APYQuantity), apycyl.phi[-1])
assert np.allclose(convert(cyl.z, APYQuantity), apycyl.z)
assert np.allclose(convert(cyl.phi, APYQuantity), apycyl.phi)

def test_spherical_to_spherical(self, vector):
"""Test ``coordinax.represent_as(SphericalVector)``."""
Expand Down
Loading