Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat(vectors): public scope function and method cartesian_type #372

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

nstarman
Copy link
Contributor

@nstarman nstarman commented Feb 5, 2025

No description provided.

@nstarman nstarman added this to the v0.20.0 milestone Feb 5, 2025
@nstarman nstarman force-pushed the vecs/cartesian_class branch 3 times, most recently from 5fd976e to 1a0a16c Compare February 6, 2025 00:02
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 95.95960% with 4 lines in your changes missing coverage. Please review.

Project coverage is 98.57%. Comparing base (6318c3a) to head (badb3ef).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...dinax/_src/vectors/base_pos/register_primitives.py 72.72% 3 Missing ⚠️
...rc/coordinax/_src/vectors/d1/register_vectorapi.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
+ Coverage   98.37%   98.57%   +0.19%     
==========================================
  Files         146      146              
  Lines        4242     4200      -42     
==========================================
- Hits         4173     4140      -33     
+ Misses         69       60       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nstarman nstarman force-pushed the vecs/cartesian_class branch from 1a0a16c to badb3ef Compare February 6, 2025 00:36
@nstarman nstarman marked this pull request as ready for review February 6, 2025 00:49
@nstarman nstarman merged commit 1270b58 into GalacticDynamics:main Feb 6, 2025
16 of 17 checks passed
@nstarman nstarman deleted the vecs/cartesian_class branch February 6, 2025 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant