Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Astropy conversion via plum #22

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Conversation

nstarman
Copy link
Contributor

@nstarman nstarman commented Feb 24, 2024

See #21 for necessary followup to address this bug.

@nstarman nstarman added this to the v0.1 milestone Feb 24, 2024
Copy link

codecov bot commented Feb 24, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 6 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@ae12528). Click here to learn what that means.

Files Patch % Lines
src/vector/_d3/compat.py 85.36% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage        ?   97.83%           
=======================================
  Files           ?       20           
  Lines           ?      555           
  Branches        ?        0           
=======================================
  Hits            ?      543           
  Misses          ?       12           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nstarman nstarman merged commit 0fa7b43 into GalacticDynamics:main Feb 24, 2024
13 checks passed
@nstarman nstarman deleted the test-astropy branch February 24, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant