Fixed dupe bug with breaking of compacting drawer #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compacting drawer is implemented so that all items it displays are not just visuals - ones are virtually stored.
For example, when you put stack of gold inside compacting drawer, it creates 7 blocks of gold and 9 stacks of golden nuggets. And when broken such drawer drops all its contents which leads to dupe.
This PR fixes this issue by clearing slot contents of drawer after dropping items it world (which results in recalculation of amount of real items stored).
Supersedes #23
Testing is required (especially for regular drawers, because this PR changes logic of breaking of all drawers)