Customizable Lootbag icons #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glease
reviewed
Dec 14, 2024
|
you can reload lists and change items and complete lists ingame |
|
like /lbags reload |
Would you expect icon changes in the XML file to be reflected when that command runs? That could potentially be a bit trickier. |
|
reload the list ingame is a handy feature but change the icon is not necessary i would say. |
|
dream can run a resource pack reload himself. f3+t or just go to the resource pack view both works. no need to get fully automatic since that'd be quite complicated |
serenibyss
approved these changes
Dec 18, 2024
Dream-Master
pushed a commit
that referenced
this pull request
Dec 18, 2024
(cherry picked from commit 1cfaad2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out this was a planned feature that never got finished. Replaced vestigial code with functioning feature to allow specifying custom item icons per lootbag.
More work required
This is all of the required code changes for this feature, but it won't change anything in the pack. New icons need to be added in https://github.com/GTNewHorizons/NewHorizonsCoreMod and those need to be referenced in https://github.com/GTNewHorizons/GT-New-Horizons-Modpack/blob/master/config/EnhancedLootBags/LootBags.xml.
Sample usage
Add the desired lootbag icon to some other mod (like the GTNH core mod) under
%MODID%/textures/items/.Reference the icon by combined mod Id and item texture name using the
LootbagIconproperty ofLootGrouptags inLootBags.xml.Proof of concept test icons (Not included)