Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1846 No JSON file generation for needs review #1857

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

gchi25
Copy link
Contributor

@gchi25 gchi25 commented Oct 4, 2024

PR Summary

This work adds code to not generate JSON files when content changing to needs review state.

Related Github Issue

Detailed Testing steps

To test in local development site or in dev site.

  • Confirm PR 1710 content workflow #1842 merged.
  • Pull changes locally
  • Make local development site up at http://localhost
  • If in local, bin/drush cim --partial --source=modules/custom/usagov_benefit_finder/configuration -y
  • Navigate to admin/content?combine=&type=bears_agency&status=All&langcode=All
  • Go to agency "Department of Education (DOE)" edit page
  • Change to Draft
  • CLICK Save
  • Verify JSON file generation
  • Go to agency "Department of Education (DOE)" edit page
  • Change to Needs Review
  • CLICK Save
  • Verify no JSON file generation
  • Verify seeing warning message

@gchi25 gchi25 self-assigned this Oct 4, 2024
@scottqueen-bixal scottqueen-bixal merged commit cac6263 into dev Oct 9, 2024
6 checks passed
@scottqueen-bixal scottqueen-bixal deleted the 1846-needs-review-no-json-file branch October 9, 2024 13:10
@gchi25 gchi25 added this to the v0.8.0.beta.1 milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No JSON file generation for moderation state Needs Review
2 participants