Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inventory-item-has-software-version constraint #1039

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Add inventory-item-has-software-version constraint #1039

merged 2 commits into from
Jan 7, 2025

Conversation

Gabeblis
Copy link
Contributor

@Gabeblis Gabeblis commented Dec 26, 2024 •
edited
Loading

Committer Notes

Purpose

This PR aims to add the inventory-item-has-software-version constraint which ensures that every inventory items has a "os-version" or "software-version"

Changes

Added constraint:

  • inventory-item-has-software-version

Added valid/invalid test content:

  • ssp-inventory-item-has-software-version-INVALID.xml
  • Edited fedramp-ssp-example.oscal.xml to align with constraint

Added yaml files for testing:

  • Pass/fail yaml tests added for each of the above constraints.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis self-assigned this Dec 26, 2024
@Gabeblis Gabeblis requested a review from a team as a code owner December 26, 2024 13:45
kyhu65867
kyhu65867 previously approved these changes Dec 26, 2024
View reviewed changes
Copy link

@kyhu65867 kyhu65867 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@Gabeblis Gabeblis force-pushed the constraints/issue-1036 branch from 1ef66a0 to fdd39f0 Compare December 26, 2024 13:49
@Gabeblis Gabeblis force-pushed the constraints/issue-1036 branch from fdd39f0 to dc20b52 Compare December 26, 2024 13:49
@Gabeblis Gabeblis requested review from kyhu65867 and a team December 26, 2024 13:52
@Gabeblis Gabeblis changed the title Add inventory-item-has-software-version constraint [DO NOT MERGE] Add inventory-item-has-software-version constraint Dec 26, 2024
@Gabeblis Gabeblis force-pushed the constraints/issue-1036 branch 2 times, most recently from 30f246a to 00217c2 Compare December 26, 2024 18:06
@Gabeblis Gabeblis linked an issue Dec 26, 2024 that may be closed by this pull request
Inventory - OS or Software Version #1036
Open
15 tasks
@Gabeblis Gabeblis mentioned this pull request Dec 26, 2024
Open
15 tasks
@Gabeblis Gabeblis force-pushed the constraints/issue-1036 branch from 00217c2 to c47b8b6 Compare December 27, 2024 15:10
@Gabeblis Gabeblis force-pushed the constraints/issue-1036 branch from e7bd987 to 51e8e19 Compare December 27, 2024 22:34
@Gabeblis Gabeblis changed the title [DO NOT MERGE] Add inventory-item-has-software-version constraint Add inventory-item-has-software-version constraint Dec 29, 2024
@Gabeblis
Copy link
Contributor Author

@Rene2mt As of right now, upstream allowed-values don't allow for a 'software-version' prop in a component. Tests fail when I try to add the example of an inventory-item not having the prop, but the linked component does have it.

@wandmagic
Copy link

needs a rebase, but looks good to me

@Gabeblis Gabeblis force-pushed the constraints/issue-1036 branch from 51e8e19 to 485f64b Compare December 30, 2024 15:33
Rene2mt
Rene2mt previously approved these changes Dec 30, 2024
View reviewed changes
wandmagic
wandmagic previously approved these changes Dec 30, 2024
View reviewed changes
@Gabeblis Gabeblis dismissed stale reviews from wandmagic and Rene2mt via 0419936 December 30, 2024 19:13
@Gabeblis Gabeblis force-pushed the constraints/issue-1036 branch from 485f64b to 0419936 Compare December 30, 2024 19:13
@Rene2mt
Copy link
Member

Rene2mt commented Dec 31, 2024

@Rene2mt As of right now, upstream allowed-values don't allow for a 'software-version' prop in a component. Tests fail when I try to add the example of an inventory-item not having the prop, but the linked component does have it.

@Gabeblis this is similar to 1038 where the prop we need isnot supported by upstream OSCAL. We're discussing several options - see #1038 (comment)

@Gabeblis Gabeblis force-pushed the constraints/issue-1036 branch from 0419936 to 0eb17eb Compare January 6, 2025 12:03
@Gabeblis Gabeblis changed the base branch from develop to canary January 7, 2025 18:11
@Gabeblis Gabeblis merged commit ec7affc into GSA:canary Jan 7, 2025
6 checks passed
wandmagic pushed a commit to wandmagic/fedramp-automation that referenced this pull request Jan 10, 2025
@Gabeblis @wandmagic
Add inventory-item-has-software-version constraint (GSA#1039)
f556138 
* Add 'inventory-item-has-software-version' constraint and tests

* Add 'inventory-item-has-software-version' constraint and tests
wandmagic added a commit to brian-ruf/fedramp-automation that referenced this pull request Jan 10, 2025
@wandmagic
Squashed commit of the following:
ea06f41 
commit 7c6b0f2
Merge: f10ace6 26f4f19
Author: ~ . ~ <[email protected]>
Date:   Fri Jan 10 11:49:42 2025 -0500

    Merge branch 'canary' of https://github.com/wandmagic/fedramp-automation into canary

commit f10ace6
Author: ~ . ~ <[email protected]>
Date:   Wed Jan 8 11:06:00 2025 -0500

    use latest server build

commit d7af65c
Author: ~ . ~ <[email protected]>
Date:   Tue Jan 7 22:21:48 2025 -0500

    hotfix missing expect tag

commit ee65d47
Author: ~ . ~ <[email protected]>
Date:   Tue Jan 7 17:17:54 2025 -0500

    use preview versions of oscal tools

commit b9ca17a
Author: Gabeblis <[email protected]>
Date:   Tue Jan 7 13:12:47 2025 -0500

    Add 'inventory-item-has-software-name' constraint and tests (GSA#1038)

commit f556138
Author: Gabeblis <[email protected]>
Date:   Tue Jan 7 13:11:13 2025 -0500

    Add `inventory-item-has-software-version` constraint (GSA#1039)

    * Add 'inventory-item-has-software-version' constraint and tests

    * Add 'inventory-item-has-software-version' constraint and tests

commit 60ba7f7
Author: wandmagic <[email protected]>
Date:   Fri Jan 10 11:15:47 2025 -0500

    add inventory item constraints (GSA#1063)

    * add inventory item constraints

    * update example file

    Co-Authored-By: A.J. Stein <[email protected]>

    * improve scan type constraint

    * massage constraints

    * improve constraint content

    * Update src/validations/constraints/fedramp-external-constraints.xml

    Co-authored-by: Gabeblis <[email protected]>

    * Update src/validations/constraints/fedramp-external-constraints.xml

    Co-authored-by: Gabeblis <[email protected]>

    * Update fedramp-external-constraints.xml

    * Update fedramp-external-constraints.xml

    * Squashed commit of the following:

    commit d7b0623
    Author: wandmagic <[email protected]>
    Date:   Tue Jan 7 14:47:44 2025 -0500

        fix constraints (GSA#1070)

    commit fc50a42
    Author: wandmagic <[email protected]>
    Date:   Fri Jan 3 14:21:47 2025 -0500

        hotfix develop (GSA#1064)

    * Squashed commit of the following:

    commit 18a02c9
    Author: wandmagic <[email protected]>
    Date:   Wed Jan 8 09:37:15 2025 -0500

        Hotfix styles (GSA#1076)

        * style guide hotfix

        * Update fedramp-external-constraints.xml

    commit 60b3c50
    Author: DimitriZhurkin <[email protected]>
    Date:   Wed Jan 8 07:14:14 2025 -0700

        Add the inter-boundary-component-has-information-type constraint (GSA#1066)

        * Add the inter-boundary-component-has-information-type constraint

        * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml

    commit d7b0623
    Author: wandmagic <[email protected]>
    Date:   Tue Jan 7 14:47:44 2025 -0500

        fix constraints (GSA#1070)

    commit fc50a42
    Author: wandmagic <[email protected]>
    Date:   Fri Jan 3 14:21:47 2025 -0500

        hotfix develop (GSA#1064)

    * Squashed commit of the following:

    commit 8c1a343
    Author: Gabeblis <[email protected]>
    Date:   Thu Jan 9 11:45:37 2025 -0500

        Add new metapath target to 'security-level' constraint (GSA#1079)

    commit 608080d
    Author: wandmagic <[email protected]>
    Date:   Thu Jan 9 09:29:17 2025 -0500

        add additional sample content (GSA#1081)

    commit 1f55a73
    Author: Gabeblis <[email protected]>
    Date:   Thu Jan 9 09:22:28 2025 -0500

        Correct constraint message. (GSA#1085)

    commit 18a02c9
    Author: wandmagic <[email protected]>
    Date:   Wed Jan 8 09:37:15 2025 -0500

        Hotfix styles (GSA#1076)

        * style guide hotfix

        * Update fedramp-external-constraints.xml

    commit 60b3c50
    Author: DimitriZhurkin <[email protected]>
    Date:   Wed Jan 8 07:14:14 2025 -0700

        Add the inter-boundary-component-has-information-type constraint (GSA#1066)

        * Add the inter-boundary-component-has-information-type constraint

        * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml

    commit d7b0623
    Author: wandmagic <[email protected]>
    Date:   Tue Jan 7 14:47:44 2025 -0500

        fix constraints (GSA#1070)

    commit fc50a42
    Author: wandmagic <[email protected]>
    Date:   Fri Jan 3 14:21:47 2025 -0500

        hotfix develop (GSA#1064)

    ---------

    Co-authored-by: A.J. Stein <[email protected]>
    Co-authored-by: Gabeblis <[email protected]>

commit 5e3f386
Author: wandmagic <[email protected]>
Date:   Fri Jan 10 09:25:07 2025 -0500

    make build (GSA#1080)

commit 8c1a343
Author: Gabeblis <[email protected]>
Date:   Thu Jan 9 11:45:37 2025 -0500

    Add new metapath target to 'security-level' constraint (GSA#1079)

commit 608080d
Author: wandmagic <[email protected]>
Date:   Thu Jan 9 09:29:17 2025 -0500

    add additional sample content (GSA#1081)

commit 1f55a73
Author: Gabeblis <[email protected]>
Date:   Thu Jan 9 09:22:28 2025 -0500

    Correct constraint message. (GSA#1085)

commit 26f4f19
Author: ~ . ~ <[email protected]>
Date:   Wed Jan 8 11:06:00 2025 -0500

    use latest server build

commit 18a02c9
Author: wandmagic <[email protected]>
Date:   Wed Jan 8 09:37:15 2025 -0500

    Hotfix styles (GSA#1076)

    * style guide hotfix

    * Update fedramp-external-constraints.xml

commit 60b3c50
Author: DimitriZhurkin <[email protected]>
Date:   Wed Jan 8 07:14:14 2025 -0700

    Add the inter-boundary-component-has-information-type constraint (GSA#1066)

    * Add the inter-boundary-component-has-information-type constraint

    * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml

commit dd20034
Author: ~ . ~ <[email protected]>
Date:   Tue Jan 7 22:21:48 2025 -0500

    hotfix missing expect tag

commit b4d3df5
Author: ~ . ~ <[email protected]>
Date:   Tue Jan 7 17:17:54 2025 -0500

    use preview versions of oscal tools

commit 719cf2c
Author: Gabeblis <[email protected]>
Date:   Tue Jan 7 13:12:47 2025 -0500

    Add 'inventory-item-has-software-name' constraint and tests (GSA#1038)

commit ec7affc
Author: Gabeblis <[email protected]>
Date:   Tue Jan 7 13:11:13 2025 -0500

    Add `inventory-item-has-software-version` constraint (GSA#1039)

    * Add 'inventory-item-has-software-version' constraint and tests

    * Add 'inventory-item-has-software-version' constraint and tests
wandmagic added a commit to wandmagic/fedramp-automation that referenced this pull request Jan 10, 2025
@wandmagic
Squashed commit of the following:
cdf2fa6 
commit 7c6b0f2
Merge: f10ace6 26f4f19
Author: ~ . ~ <[email protected]>
Date:   Fri Jan 10 11:49:42 2025 -0500

    Merge branch 'canary' of https://github.com/wandmagic/fedramp-automation into canary

commit f10ace6
Author: ~ . ~ <[email protected]>
Date:   Wed Jan 8 11:06:00 2025 -0500

    use latest server build

commit d7af65c
Author: ~ . ~ <[email protected]>
Date:   Tue Jan 7 22:21:48 2025 -0500

    hotfix missing expect tag

commit ee65d47
Author: ~ . ~ <[email protected]>
Date:   Tue Jan 7 17:17:54 2025 -0500

    use preview versions of oscal tools

commit b9ca17a
Author: Gabeblis <[email protected]>
Date:   Tue Jan 7 13:12:47 2025 -0500

    Add 'inventory-item-has-software-name' constraint and tests (GSA#1038)

commit f556138
Author: Gabeblis <[email protected]>
Date:   Tue Jan 7 13:11:13 2025 -0500

    Add `inventory-item-has-software-version` constraint (GSA#1039)

    * Add 'inventory-item-has-software-version' constraint and tests

    * Add 'inventory-item-has-software-version' constraint and tests

commit 60ba7f7
Author: wandmagic <[email protected]>
Date:   Fri Jan 10 11:15:47 2025 -0500

    add inventory item constraints (GSA#1063)

    * add inventory item constraints

    * update example file

    Co-Authored-By: A.J. Stein <[email protected]>

    * improve scan type constraint

    * massage constraints

    * improve constraint content

    * Update src/validations/constraints/fedramp-external-constraints.xml

    Co-authored-by: Gabeblis <[email protected]>

    * Update src/validations/constraints/fedramp-external-constraints.xml

    Co-authored-by: Gabeblis <[email protected]>

    * Update fedramp-external-constraints.xml

    * Update fedramp-external-constraints.xml

    * Squashed commit of the following:

    commit d7b0623
    Author: wandmagic <[email protected]>
    Date:   Tue Jan 7 14:47:44 2025 -0500

        fix constraints (GSA#1070)

    commit fc50a42
    Author: wandmagic <[email protected]>
    Date:   Fri Jan 3 14:21:47 2025 -0500

        hotfix develop (GSA#1064)

    * Squashed commit of the following:

    commit 18a02c9
    Author: wandmagic <[email protected]>
    Date:   Wed Jan 8 09:37:15 2025 -0500

        Hotfix styles (GSA#1076)

        * style guide hotfix

        * Update fedramp-external-constraints.xml

    commit 60b3c50
    Author: DimitriZhurkin <[email protected]>
    Date:   Wed Jan 8 07:14:14 2025 -0700

        Add the inter-boundary-component-has-information-type constraint (GSA#1066)

        * Add the inter-boundary-component-has-information-type constraint

        * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml

    commit d7b0623
    Author: wandmagic <[email protected]>
    Date:   Tue Jan 7 14:47:44 2025 -0500

        fix constraints (GSA#1070)

    commit fc50a42
    Author: wandmagic <[email protected]>
    Date:   Fri Jan 3 14:21:47 2025 -0500

        hotfix develop (GSA#1064)

    * Squashed commit of the following:

    commit 8c1a343
    Author: Gabeblis <[email protected]>
    Date:   Thu Jan 9 11:45:37 2025 -0500

        Add new metapath target to 'security-level' constraint (GSA#1079)

    commit 608080d
    Author: wandmagic <[email protected]>
    Date:   Thu Jan 9 09:29:17 2025 -0500

        add additional sample content (GSA#1081)

    commit 1f55a73
    Author: Gabeblis <[email protected]>
    Date:   Thu Jan 9 09:22:28 2025 -0500

        Correct constraint message. (GSA#1085)

    commit 18a02c9
    Author: wandmagic <[email protected]>
    Date:   Wed Jan 8 09:37:15 2025 -0500

        Hotfix styles (GSA#1076)

        * style guide hotfix

        * Update fedramp-external-constraints.xml

    commit 60b3c50
    Author: DimitriZhurkin <[email protected]>
    Date:   Wed Jan 8 07:14:14 2025 -0700

        Add the inter-boundary-component-has-information-type constraint (GSA#1066)

        * Add the inter-boundary-component-has-information-type constraint

        * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml

    commit d7b0623
    Author: wandmagic <[email protected]>
    Date:   Tue Jan 7 14:47:44 2025 -0500

        fix constraints (GSA#1070)

    commit fc50a42
    Author: wandmagic <[email protected]>
    Date:   Fri Jan 3 14:21:47 2025 -0500

        hotfix develop (GSA#1064)

    ---------

    Co-authored-by: A.J. Stein <[email protected]>
    Co-authored-by: Gabeblis <[email protected]>

commit 5e3f386
Author: wandmagic <[email protected]>
Date:   Fri Jan 10 09:25:07 2025 -0500

    make build (GSA#1080)

commit 8c1a343
Author: Gabeblis <[email protected]>
Date:   Thu Jan 9 11:45:37 2025 -0500

    Add new metapath target to 'security-level' constraint (GSA#1079)

commit 608080d
Author: wandmagic <[email protected]>
Date:   Thu Jan 9 09:29:17 2025 -0500

    add additional sample content (GSA#1081)

commit 1f55a73
Author: Gabeblis <[email protected]>
Date:   Thu Jan 9 09:22:28 2025 -0500

    Correct constraint message. (GSA#1085)

commit 26f4f19
Author: ~ . ~ <[email protected]>
Date:   Wed Jan 8 11:06:00 2025 -0500

    use latest server build

commit 18a02c9
Author: wandmagic <[email protected]>
Date:   Wed Jan 8 09:37:15 2025 -0500

    Hotfix styles (GSA#1076)

    * style guide hotfix

    * Update fedramp-external-constraints.xml

commit 60b3c50
Author: DimitriZhurkin <[email protected]>
Date:   Wed Jan 8 07:14:14 2025 -0700

    Add the inter-boundary-component-has-information-type constraint (GSA#1066)

    * Add the inter-boundary-component-has-information-type constraint

    * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml

commit dd20034
Author: ~ . ~ <[email protected]>
Date:   Tue Jan 7 22:21:48 2025 -0500

    hotfix missing expect tag

commit b4d3df5
Author: ~ . ~ <[email protected]>
Date:   Tue Jan 7 17:17:54 2025 -0500

    use preview versions of oscal tools

commit d7b0623
Author: wandmagic <[email protected]>
Date:   Tue Jan 7 14:47:44 2025 -0500

    fix constraints (GSA#1070)

commit 719cf2c
Author: Gabeblis <[email protected]>
Date:   Tue Jan 7 13:12:47 2025 -0500

    Add 'inventory-item-has-software-name' constraint and tests (GSA#1038)

commit ec7affc
Author: Gabeblis <[email protected]>
Date:   Tue Jan 7 13:11:13 2025 -0500

    Add `inventory-item-has-software-version` constraint (GSA#1039)

    * Add 'inventory-item-has-software-version' constraint and tests

    * Add 'inventory-item-has-software-version' constraint and tests

commit fc50a42
Author: wandmagic <[email protected]>
Date:   Fri Jan 3 14:21:47 2025 -0500

    hotfix develop (GSA#1064)

commit d8a9ec9
Author: DimitriZhurkin <[email protected]>
Date:   Fri Jan 3 11:20:23 2025 -0700

    Add connection-security constraint (issue GSA#961) (GSA#1021)

    * Add connection-security constraint (issue GSA#961)

    * change fedramp ns to http

    * Add help-url

commit 1648871
Author: Kylie Hunter <[email protected]>
Date:   Fri Jan 3 13:02:59 2025 -0500

    Image has checksum (GSA#1053)

    * test scaffolds added

    * initial attempt at writing pass and fail content

    * feature file

    * revised target to appropriate place

    * removed old target

    * added in proper ns

    * Update src/validations/constraints/fedramp-external-constraints.xml

    Co-authored-by: A.J. Stein <[email protected]>

    * AJ suggestion for more complete example

    * added comments

    ---------

    Co-authored-by: A.J. Stein <[email protected]>

commit 962a9c0
Author: Gabeblis <[email protected]>
Date:   Fri Jan 3 12:31:04 2025 -0500

    Add 'inventory-item-or-component-has-asset-id' constraint and tests (GSA#1056)

commit 836b224
Author: Rene Tshiteya <[email protected]>
Date:   Fri Jan 3 12:25:35 2025 -0500

    Fix implemented-component component-uuid references (GSA#1059)

    Fix component issues

commit 7018c20
Author: Gabeblis <[email protected]>
Date:   Fri Jan 3 12:24:47 2025 -0500

    Add 'inventory-item-has-valid-mac-address' constraint and tests (GSA#1057)
wandmagic added a commit to wandmagic/fedramp-automation that referenced this pull request Jan 13, 2025
@wandmagic
Squashed commit of the following:
042a250 
commit 719cf2c
Author: Gabeblis <[email protected]>
Date:   Tue Jan 7 13:12:47 2025 -0500

    Add 'inventory-item-has-software-name' constraint and tests (GSA#1038)

commit ec7affc
Author: Gabeblis <[email protected]>
Date:   Tue Jan 7 13:11:13 2025 -0500

    Add `inventory-item-has-software-version` constraint (GSA#1039)

    * Add 'inventory-item-has-software-version' constraint and tests

    * Add 'inventory-item-has-software-version' constraint and tests

commit fc50a42
Author: wandmagic <[email protected]>
Date:   Fri Jan 3 14:21:47 2025 -0500

    hotfix develop (GSA#1064)

commit d8a9ec9
Author: DimitriZhurkin <[email protected]>
Date:   Fri Jan 3 11:20:23 2025 -0700

    Add connection-security constraint (issue GSA#961) (GSA#1021)

    * Add connection-security constraint (issue GSA#961)

    * change fedramp ns to http

    * Add help-url

commit 1648871
Author: Kylie Hunter <[email protected]>
Date:   Fri Jan 3 13:02:59 2025 -0500

    Image has checksum (GSA#1053)

    * test scaffolds added

    * initial attempt at writing pass and fail content

    * feature file

    * revised target to appropriate place

    * removed old target

    * added in proper ns

    * Update src/validations/constraints/fedramp-external-constraints.xml

    Co-authored-by: A.J. Stein <[email protected]>

    * AJ suggestion for more complete example

    * added comments

    ---------

    Co-authored-by: A.J. Stein <[email protected]>

commit 962a9c0
Author: Gabeblis <[email protected]>
Date:   Fri Jan 3 12:31:04 2025 -0500

    Add 'inventory-item-or-component-has-asset-id' constraint and tests (GSA#1056)

commit 836b224
Author: Rene Tshiteya <[email protected]>
Date:   Fri Jan 3 12:25:35 2025 -0500

    Fix implemented-component component-uuid references (GSA#1059)

    Fix component issues

commit 7018c20
Author: Gabeblis <[email protected]>
Date:   Fri Jan 3 12:24:47 2025 -0500

    Add 'inventory-item-has-valid-mac-address' constraint and tests (GSA#1057)
wandmagic added a commit that referenced this pull request Jan 13, 2025
@wandmagic @DimitriZhurkin
@Gabeblis @aj-stein-gsa
use preview versions of oscal tools (#1072)
26d8e2b 
* fix constraints (#1070)

* use preview versions of oscal tools

* hotfix missing expect tag

* Add the inter-boundary-component-has-information-type constraint (#1066)

* Add the inter-boundary-component-has-information-type constraint

* clean up ssp-inter-boundary-component-has-information-type-INVALID.xml

* Hotfix styles (#1076)

* style guide hotfix

* Update fedramp-external-constraints.xml

* use latest server build

* Correct constraint message. (#1085)

* add additional sample content (#1081)

* Add new metapath target to 'security-level' constraint (#1079)

* make build (#1080)

* add inventory item constraints (#1063)

* add inventory item constraints

* update example file

Co-Authored-By: A.J. Stein <[email protected]>

* improve scan type constraint

* massage constraints

* improve constraint content

* Update src/validations/constraints/fedramp-external-constraints.xml

Co-authored-by: Gabeblis <[email protected]>

* Update src/validations/constraints/fedramp-external-constraints.xml

Co-authored-by: Gabeblis <[email protected]>

* Update fedramp-external-constraints.xml

* Update fedramp-external-constraints.xml

* Squashed commit of the following:

commit d7b0623
Author: wandmagic <[email protected]>
Date:   Tue Jan 7 14:47:44 2025 -0500

    fix constraints (#1070)

commit fc50a42
Author: wandmagic <[email protected]>
Date:   Fri Jan 3 14:21:47 2025 -0500

    hotfix develop (#1064)

* Squashed commit of the following:

commit 18a02c9
Author: wandmagic <[email protected]>
Date:   Wed Jan 8 09:37:15 2025 -0500

    Hotfix styles (#1076)

    * style guide hotfix

    * Update fedramp-external-constraints.xml

commit 60b3c50
Author: DimitriZhurkin <[email protected]>
Date:   Wed Jan 8 07:14:14 2025 -0700

    Add the inter-boundary-component-has-information-type constraint (#1066)

    * Add the inter-boundary-component-has-information-type constraint

    * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml

commit d7b0623
Author: wandmagic <[email protected]>
Date:   Tue Jan 7 14:47:44 2025 -0500

    fix constraints (#1070)

commit fc50a42
Author: wandmagic <[email protected]>
Date:   Fri Jan 3 14:21:47 2025 -0500

    hotfix develop (#1064)

* Squashed commit of the following:

commit 8c1a343
Author: Gabeblis <[email protected]>
Date:   Thu Jan 9 11:45:37 2025 -0500

    Add new metapath target to 'security-level' constraint (#1079)

commit 608080d
Author: wandmagic <[email protected]>
Date:   Thu Jan 9 09:29:17 2025 -0500

    add additional sample content (#1081)

commit 1f55a73
Author: Gabeblis <[email protected]>
Date:   Thu Jan 9 09:22:28 2025 -0500

    Correct constraint message. (#1085)

commit 18a02c9
Author: wandmagic <[email protected]>
Date:   Wed Jan 8 09:37:15 2025 -0500

    Hotfix styles (#1076)

    * style guide hotfix

    * Update fedramp-external-constraints.xml

commit 60b3c50
Author: DimitriZhurkin <[email protected]>
Date:   Wed Jan 8 07:14:14 2025 -0700

    Add the inter-boundary-component-has-information-type constraint (#1066)

    * Add the inter-boundary-component-has-information-type constraint

    * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml

commit d7b0623
Author: wandmagic <[email protected]>
Date:   Tue Jan 7 14:47:44 2025 -0500

    fix constraints (#1070)

commit fc50a42
Author: wandmagic <[email protected]>
Date:   Fri Jan 3 14:21:47 2025 -0500

    hotfix develop (#1064)

---------

Co-authored-by: A.J. Stein <[email protected]>
Co-authored-by: Gabeblis <[email protected]>

* Add `inventory-item-has-software-version` constraint (#1039)

* Add 'inventory-item-has-software-version' constraint and tests

* Add 'inventory-item-has-software-version' constraint and tests

* Add 'inventory-item-has-software-name' constraint and tests (#1038)

* use preview versions of oscal tools

* hotfix missing expect tag

* use latest server build

* fix order and missing expect closing tag

* Update fedramp-external-constraints.xml

* use versions matrix for snapshot testing

This reverts commit 5679abd.

* better action names

* Update module.mk

* Update .tool-versions

---------

Co-authored-by: DimitriZhurkin <[email protected]>
Co-authored-by: Gabeblis <[email protected]>
Co-authored-by: A.J. Stein <[email protected]>
wandmagic pushed a commit to wandmagic/fedramp-automation that referenced this pull request Feb 3, 2025
@Gabeblis @wandmagic
Add inventory-item-has-software-version constraint (GSA#1039)
a4c843e 
* Add 'inventory-item-has-software-version' constraint and tests

* Add 'inventory-item-has-software-version' constraint and tests
wandmagic pushed a commit to wandmagic/fedramp-automation that referenced this pull request Feb 3, 2025
@Gabeblis @wandmagic
Add inventory-item-has-software-version constraint (GSA#1039)
475dd1b 
* Add 'inventory-item-has-software-version' constraint and tests

* Add 'inventory-item-has-software-version' constraint and tests
wandmagic added a commit to wandmagic/fedramp-automation that referenced this pull request Feb 3, 2025
@wandmagic @DimitriZhurkin
@Gabeblis @aj-stein-gsa
use preview versions of oscal tools (GSA#1072)
651515f 
* fix constraints (GSA#1070)

* use preview versions of oscal tools

* hotfix missing expect tag

* Add the inter-boundary-component-has-information-type constraint (GSA#1066)

* Add the inter-boundary-component-has-information-type constraint

* clean up ssp-inter-boundary-component-has-information-type-INVALID.xml

* Hotfix styles (GSA#1076)

* style guide hotfix

* Update fedramp-external-constraints.xml

* use latest server build

* Correct constraint message. (GSA#1085)

* add additional sample content (GSA#1081)

* Add new metapath target to 'security-level' constraint (GSA#1079)

* make build (GSA#1080)

* add inventory item constraints (GSA#1063)

* add inventory item constraints

* update example file

Co-Authored-By: A.J. Stein <[email protected]>

* improve scan type constraint

* massage constraints

* improve constraint content

* Update src/validations/constraints/fedramp-external-constraints.xml

Co-authored-by: Gabeblis <[email protected]>

* Update src/validations/constraints/fedramp-external-constraints.xml

Co-authored-by: Gabeblis <[email protected]>

* Update fedramp-external-constraints.xml

* Update fedramp-external-constraints.xml

* Squashed commit of the following:

commit d7b0623
Author: wandmagic <[email protected]>
Date:   Tue Jan 7 14:47:44 2025 -0500

    fix constraints (GSA#1070)

commit fc50a42
Author: wandmagic <[email protected]>
Date:   Fri Jan 3 14:21:47 2025 -0500

    hotfix develop (GSA#1064)

* Squashed commit of the following:

commit 18a02c9
Author: wandmagic <[email protected]>
Date:   Wed Jan 8 09:37:15 2025 -0500

    Hotfix styles (GSA#1076)

    * style guide hotfix

    * Update fedramp-external-constraints.xml

commit 60b3c50
Author: DimitriZhurkin <[email protected]>
Date:   Wed Jan 8 07:14:14 2025 -0700

    Add the inter-boundary-component-has-information-type constraint (GSA#1066)

    * Add the inter-boundary-component-has-information-type constraint

    * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml

commit d7b0623
Author: wandmagic <[email protected]>
Date:   Tue Jan 7 14:47:44 2025 -0500

    fix constraints (GSA#1070)

commit fc50a42
Author: wandmagic <[email protected]>
Date:   Fri Jan 3 14:21:47 2025 -0500

    hotfix develop (GSA#1064)

* Squashed commit of the following:

commit 8c1a343
Author: Gabeblis <[email protected]>
Date:   Thu Jan 9 11:45:37 2025 -0500

    Add new metapath target to 'security-level' constraint (GSA#1079)

commit 608080d
Author: wandmagic <[email protected]>
Date:   Thu Jan 9 09:29:17 2025 -0500

    add additional sample content (GSA#1081)

commit 1f55a73
Author: Gabeblis <[email protected]>
Date:   Thu Jan 9 09:22:28 2025 -0500

    Correct constraint message. (GSA#1085)

commit 18a02c9
Author: wandmagic <[email protected]>
Date:   Wed Jan 8 09:37:15 2025 -0500

    Hotfix styles (GSA#1076)

    * style guide hotfix

    * Update fedramp-external-constraints.xml

commit 60b3c50
Author: DimitriZhurkin <[email protected]>
Date:   Wed Jan 8 07:14:14 2025 -0700

    Add the inter-boundary-component-has-information-type constraint (GSA#1066)

    * Add the inter-boundary-component-has-information-type constraint

    * clean up ssp-inter-boundary-component-has-information-type-INVALID.xml

commit d7b0623
Author: wandmagic <[email protected]>
Date:   Tue Jan 7 14:47:44 2025 -0500

    fix constraints (GSA#1070)

commit fc50a42
Author: wandmagic <[email protected]>
Date:   Fri Jan 3 14:21:47 2025 -0500

    hotfix develop (GSA#1064)

---------

Co-authored-by: A.J. Stein <[email protected]>
Co-authored-by: Gabeblis <[email protected]>

* Add `inventory-item-has-software-version` constraint (GSA#1039)

* Add 'inventory-item-has-software-version' constraint and tests

* Add 'inventory-item-has-software-version' constraint and tests

* Add 'inventory-item-has-software-name' constraint and tests (GSA#1038)

* use preview versions of oscal tools

* hotfix missing expect tag

* use latest server build

* fix order and missing expect closing tag

* Update fedramp-external-constraints.xml

* use versions matrix for snapshot testing

This reverts commit 5679abd.

* better action names

* Update module.mk

* Update .tool-versions

---------

Co-authored-by: DimitriZhurkin <[email protected]>
Co-authored-by: Gabeblis <[email protected]>
Co-authored-by: A.J. Stein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rene2mt Rene2mt Rene2mt left review comments

@wandmagic wandmagic wandmagic left review comments

@kyhu65867 kyhu65867 Awaiting requested review from kyhu65867

@aj-stein-gsa aj-stein-gsa Awaiting requested review from aj-stein-gsa

Assignees

@Gabeblis Gabeblis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inventory - OS or Software Version
5 participants
@Gabeblis @wandmagic @Rene2mt @aj-stein-gsa @kyhu65867