Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mac and Windows builds to github actions #228

Merged
merged 10 commits into from
Feb 11, 2025
Merged

Conversation

vberthiaume
Copy link
Member

No description provided.

@vberthiaume vberthiaume requested a review from jcelerier February 7, 2025 20:07
<CONFIGURATION isDebug="1" name="Debug" enablePluginBinaryCopyStep="1" vst3BinaryLocation="C:\Program Files\Common Files\VST3"/>
<CONFIGURATION isDebug="0" name="Release" enablePluginBinaryCopyStep="1" vst3BinaryLocation="C:\Program Files\Common Files\VST3"/>
<CONFIGURATION isDebug="1" name="Debug" vst3BinaryLocation="C:\Program Files\Common Files\VST3"/>
<CONFIGURATION isDebug="0" name="Release" vst3BinaryLocation="C:\Program Files\Common Files\VST3"/>
Copy link
Member Author

@vberthiaume vberthiaume Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this copy step causes the windows pipeline to fail (and it was the only OS where it was enabled)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i assume that this is because of lacking administrative rights to install the VST - i'm fine with it but I think we should see how the GRIS maintainers feel about it as it's something that they may have had in their workflow

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g. i'm definitely thinking of a development workflow where you build and the VST gets copied automatically to the right place so that your DAW can use it ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it is totally useful for exactly that workflow... I was the one that added that step in the first place 😅­, but I just figured out how to remove it from the pipeline so I added it back to the jucer file 🚀

@@ -33,13 +33,6 @@ jobs:
libfreetype6-dev libx11-dev libxcomposite-dev libxcursor-dev libxinerama-dev libxrandr-dev \
mesa-common-dev libjack-dev

- name: Install dependencies
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was a duplication from the step right above

Copy link
Collaborator

@jcelerier jcelerier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@vberthiaume vberthiaume merged commit 1456499 into dev-sat Feb 11, 2025
6 checks passed
@vberthiaume vberthiaume deleted the macWinPipeline branch February 11, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants