Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/bmauer/geos simulator #3282

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Feature/bmauer/geos simulator #3282

merged 3 commits into from
Jan 6, 2025

Conversation

bena-nasa
Copy link
Collaborator

I realized my "GEOS" simulator, a script I had to generate inputs for ExtDataDriver.x to simulate an ExtData configuration that a real model run is using was not quite working right last week. I spent some time fixing it, and I don't want to loose it and it is useful enough I want to get it into version control.

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Related Issue

@bena-nasa bena-nasa added 🎁 New Feature This is a new feature 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) labels Jan 6, 2025
@bena-nasa bena-nasa requested a review from tclune January 6, 2025 16:57
@bena-nasa bena-nasa requested a review from a team as a code owner January 6, 2025 16:57
tclune
tclune previously approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't pretend to have followed all the details, but looks quite clean and thus easy to understand/improve when needed.

I did make a small code-quality suggestion - at the discretion of the implementor.

@bena-nasa bena-nasa requested a review from tclune January 6, 2025 18:26
@mathomp4 mathomp4 merged commit 65b0002 into develop Jan 6, 2025
48 checks passed
@mathomp4 mathomp4 deleted the feature/bmauer/geos_simulator branch January 6, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees
No one assigned
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) 🎁 New Feature This is a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bena-nasa @tclune @mathomp4