Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #3255 #3256

Merged
merged 2 commits into from
Dec 19, 2024
Merged

fixes #3255 #3256

merged 2 commits into from
Dec 19, 2024

Conversation

bena-nasa
Copy link
Collaborator

Fixes #3255

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Related Issue

@bena-nasa bena-nasa added 🪲 Bugfix This fixes a bug! 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels Dec 18, 2024
@bena-nasa bena-nasa requested a review from a team as a code owner December 18, 2024 20:35
@mathomp4 mathomp4 mentioned this pull request Dec 18, 2024
Closed
7 tasks
mathomp4
mathomp4 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@mathomp4 mathomp4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zero diff in my testing. I assume @bena-nasa tested the actual bug fixes.

@mathomp4 mathomp4 merged commit 1c55973 into main Dec 19, 2024
48 checks passed
@mathomp4 mathomp4 deleted the hotfix/bmauer/fixes-#3255 branch December 19, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🪲 Bugfix This fixes a bug!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User found issues with Vector handling in ExtData2G
2 participants
@bena-nasa @mathomp4