Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trajectory sampler: minor bug fix #3168

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Conversation

metdyn
Copy link
Contributor

@metdyn metdyn commented Nov 8, 2024

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

This modification affects only the sampler code, especially the trajectory sampler. It fixes the following bugs:

  • When group_name does not exist in netCDF file, the sampler code complains.
  • The first time point was omitted when the model start time falls outside the time range for the trajectory. It is a valid setup.

Related Issue

I left some comments in the code, because I want to further test sampler code. More clean up will be performed afterwards.

…mple

- add missing if group_name /=''
- add back the missing first time point in trajectory
@metdyn metdyn added the 🪲 Bugfix This fixes a bug! label Nov 8, 2024
@metdyn metdyn requested a review from a team as a code owner November 8, 2024 22:19
@metdyn metdyn added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Nov 8, 2024
@metdyn metdyn requested review from tclune and bena-nasa November 10, 2024 17:57
@tclune tclune merged commit 18567fa into develop Nov 12, 2024
35 of 37 checks passed
@tclune tclune deleted the feature/ygyu/test_sampler_Nov_8 branch November 12, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🪲 Bugfix This fixes a bug!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants