Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for NVHPC 24.5 #2856

Merged
merged 5 commits into from
Jun 18, 2024
Merged

Fixes for NVHPC 24.5 #2856

merged 5 commits into from
Jun 18, 2024

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Jun 4, 2024 •
edited
Loading

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

This PR is collecting changes needed for NVHPC work. Note that none of this has been tested yet. The PR here is to make sure I don't lose it!

Changes:

  • Update to MAPL_GeosatMaskMod code from @metdyn to echo the style of submodules being done by @JulesKouatchou. Not sure why just this code NVHPC tripped over, but it seems to be okay with this.

Related Issue

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Jun 4, 2024
@mathomp4 mathomp4 self-assigned this Jun 4, 2024
@mathomp4 mathomp4 marked this pull request as ready for review June 17, 2024 17:16
@mathomp4 mathomp4 requested a review from a team as a code owner June 17, 2024 17:16
tclune
tclune approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like most of the issues were against my preferred style of submodule use anyway.

@mathomp4 mathomp4 merged commit 5717977 into develop Jun 18, 2024
38 checks passed
@mathomp4 mathomp4 deleted the bugfix/mathomp4/nvhpc-24.5-fixes branch June 18, 2024 16:37
@mathomp4 mathomp4 mentioned this pull request Jun 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees

@mathomp4 mathomp4

Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathomp4 @tclune