Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing INT64 use #2705

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Add missing INT64 use #2705

merged 1 commit into from
Apr 3, 2024

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Apr 3, 2024

Description

It looks like in #2660 there is a missing declaration of INT64 . I'm not sure how CI passed. Hmm.

Related Issue

Motivation and Context

Let's MAPL develop and MAPL3 build again.

How Has This Been Tested?

It builds.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix labels Apr 3, 2024
@mathomp4 mathomp4 self-assigned this Apr 3, 2024
@mathomp4 mathomp4 requested a review from a team as a code owner April 3, 2024 11:39
@mathomp4
Copy link
Member Author

mathomp4 commented Apr 3, 2024

More interesting. Some of the nightly tests were happy to build and some were not.

I wonder if this could possibly be a race condition?? I'm baffled. I'll need to consult @tclune

@tclune tclune merged commit 0c40592 into develop Apr 3, 2024
38 of 41 checks passed
@tclune tclune deleted the bugfix/mathomp4/add-missing-int64 branch April 3, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atrayano atrayano atrayano approved these changes

@tclune tclune tclune approved these changes

Assignees

@mathomp4 mathomp4

Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathomp4 @tclune @atrayano