Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge R21C into develop: Compress lats and lons in CS output if deflate requested #2689

Merged
merged 5 commits into from
Mar 28, 2024

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Mar 28, 2024

Description

Closes #2683

If the variables in a collection are compressed, compress the coordinate variables too, just silly not too...

NOTE: This is zero-diff in regards to the state, but it will change a binary comparison of netcdf history output.

This is an attempt to merge from R21C into develop

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

mathomp4 and others added 5 commits July 10, 2023 14:28
This release backports fixes for ExtData2G handling of climatologies
in weird circumstances and a fix for HISTORY handling of 1-bin
output from GOCART.
@mathomp4 mathomp4 requested a review from a team as a code owner March 28, 2024 15:22
@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Mar 28, 2024
@mathomp4 mathomp4 self-assigned this Mar 28, 2024
@tclune tclune merged commit a9aa9d7 into develop Mar 28, 2024
34 of 35 checks passed
@tclune tclune deleted the merge/handmerge/r21c-into-mapldev branch March 28, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants