Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to allow SCM model to run #2602

Merged
merged 4 commits into from
Feb 23, 2024
Merged

Fixes to allow SCM model to run #2602

merged 4 commits into from
Feb 23, 2024

Conversation

mathomp4
Copy link
Member

Description

This PR has fixes for letting the SCM run with MAPL develop

Related Issue

Closes #2601

Motivation and Context

Let's the SCM run!

How Has This Been Tested?

Will test with SCM and GEOSgcm before undrafting

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix labels Feb 14, 2024
@mathomp4 mathomp4 self-assigned this Feb 14, 2024
@mathomp4 mathomp4 mentioned this pull request Feb 14, 2024
Closed
@mathomp4 mathomp4 linked an issue Feb 14, 2024 that may be closed by this pull request
SCM Model Failing with MAPL develop #2601
Closed
@mathomp4 mathomp4 marked this pull request as ready for review February 22, 2024 19:58
@mathomp4 mathomp4 requested a review from a team as a code owner February 22, 2024 19:58
@mathomp4
Copy link
Member Author

Confirm that SCM and GEOSgcm both happy with this (as far as I can test).

@mathomp4 mathomp4 merged commit 0d7627f into develop Feb 23, 2024
29 checks passed
@mathomp4 mathomp4 deleted the bugfix/mathomp4/scm-fixes branch February 23, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees

@mathomp4 mathomp4

Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SCM Model Failing with MAPL develop
3 participants
@mathomp4 @tclune @bena-nasa