Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/tclune/#2478 mapl abort #2479

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Hotfix/tclune/#2478 mapl abort #2479

merged 2 commits into from
Dec 6, 2023

Conversation

tclune
Copy link
Collaborator

@tclune tclune commented Dec 6, 2023

Partially tested with laptop.

(Very hard to do a unit test for this sort of thing.)

@tclune tclune added 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) bugfix ❗ High Priority This is a high priority PR labels Dec 6, 2023
@tclune tclune requested a review from a team as a code owner December 6, 2023 00:28
@tclune tclune requested a review from mathomp4 December 6, 2023 00:28
atrayano
atrayano approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@atrayano atrayano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a bug

@tclune tclune merged commit 0054b66 into main Dec 6, 2023
@tclune tclune deleted the hotfix/tclune/#2478-mapl-abort branch December 6, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atrayano atrayano atrayano approved these changes

@mathomp4 mathomp4 Awaiting requested review from mathomp4

Assignees
No one assigned
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) ❗ High Priority This is a high priority PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tclune @atrayano