Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Variable class to that you can retrieve specify attribute types #3210

Closed
bena-nasa opened this issue Dec 3, 2024 · 1 comment
Closed
Assignees
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🎁 New Feature This is a new feature

Comments

@bena-nasa
Copy link
Collaborator

I doing some work and it was helpful to have specific procedures in the Variable class in PFIO to retrieve attributes of specific types. Note there was a helper procedure in FileMetaDataUtilities.F90 that given a FileMetaDataUtilities class, a variable name, and an attribute name you could retrieve an attribute of a specific type but no way, given a Variable to retrieve.

It makes sense to do a simple refactor and move some of this into the Variable class so that this class can have the functionality to get attributes of specific types and the existing interfaces to FileMetadataUtilities can remain unchanged.

I'm just making an issue for the PR I'm going to do as I've already done the refactor.

Will make more sense when one sees the PR.

@bena-nasa bena-nasa added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels Dec 3, 2024
@bena-nasa bena-nasa self-assigned this Dec 3, 2024
@weiyuan-jiang
Copy link
Contributor

I am a little bit confused. I think the original get_attribute can just did what you added

mathomp4 added a commit that referenced this issue Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🎁 New Feature This is a new feature
Projects
None yet
Development

No branches or pull requests

2 participants