Feature/pnorris/rrtmgp validation handmerge #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # GEOSsolar_GridComp/GEOS_SolarGridComp.F90 # GEOSsolar_GridComp/RRTMG/rrtmg_sw/gcm_model/src/rrtmg_sw_rad.F90
mathomp4
added
the
0 diff
dr0cloud
previously approved these changes
Feb 21, 2024
|
Thanks to @mathomp4 for hand merging these changes. Note that they are non-zero-diff for RRTMGP but that is not run by default currently. For RRTMG they are either zero-diff or 'truncation zero-diff', but these changes should only affect diagnostic outputs and I don't think will affect the model state. One more thing. I have changed the export 'TAUTTX' to 'TAUTX'. I should check tomorrow whether this is currently included in the default HISTORY's and fix if necessary. I will do a separate PR for the @GEOS_App tomorrow. P. |
|
@dr0cloud Okay. Looks like I screwed something up with the merge as the build is failing. I'm guessing an |
dr0cloud
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.