-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Numerical derivatives for Monin-Obukhov exchange coefficients over land in offline mode #999
Draft
gmao-rreichle
wants to merge
29
commits into
develop
Choose a base branch
from
feature/rreichle/surfturb_numerical_derivatives
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Numerical derivatives for Monin-Obukhov exchange coefficients over land in offline mode #999
gmao-rreichle
wants to merge
29
commits into
develop
from
feature/rreichle/surfturb_numerical_derivatives
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changed default to NOT use extra derivs - renamed resource variable for extra derivs - reordered and moved variable declarations etc for consistency
…ge coeffs; fixed typos in comments
…S_SurfaceGridComp.rc)
…itional call to louissurface() (GEOS_CatchGridComp.F90, catch_wrap_state.F90)
@gmao-rreichle here is testing summary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0 diff
The changes in this pull request have verified to be zero-diff with the target branch.
documentation
Improvements or additions to documentation
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #918. Adds optional numerical derivatives of Monin-Obukhov exchange coefficients over land in offline mode. Numerical derivatives implemented for Louis and Helfand. Also cleans up and documents surface turbulence code in Catchment GridComp. Numerical derivatives not yet implemented for CatchCN.
New resource parameter
MOSFC_EXTRA_DERIVS_LAND
replacesincl_Louis_extra_derivs
:Successfully 0-diff tested for GEOSldas Intel standard tests at 3b6cced