Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add land constants as HISTORY export variables #970

Merged
merged 15 commits into from
Sep 13, 2024

Conversation

gmao-qliu
Copy link
Contributor

@gmao-qliu gmao-qliu commented Jul 31, 2024

Addresses #968, see for additional documentation.

Related PR: GEOS-ESM/GEOSgcm_App#636

The land constants collection defined in GEOS-ESM/GEOSgcm_App#636 matches the land constants file from MERRA-2 but now generated with MAPL HISTORY and with improved SHORT_NAME and LONG_NAME attributes.

The current file content is ok with @rdkoster and myself.

Zero-diff tests successfully conducted for AGCM and GEOSldas by @biljanaorescanin

Contents of sample land constants file verified by @gmao-qliu

@sdrabenh @biljanaorescanin @elakkraoui @rdkoster

@gmao-qliu gmao-qliu linked an issue Jul 31, 2024 that may be closed by this pull request
@gmao-qliu gmao-qliu added Needs Lead Approval Change requires science lead approval Draft labels Jul 31, 2024
gmao-qliu and others added 3 commits July 31, 2024 18:14
@gmao-qliu gmao-qliu removed the Needs Lead Approval Change requires science lead approval label Aug 2, 2024
@gmao-rreichle gmao-rreichle added enhancement New feature or request 0 diff The changes in this pull request have verified to be zero-diff with the target branch. and removed Draft labels Aug 5, 2024
@biljanaorescanin
Copy link
Contributor

biljanaorescanin commented Aug 5, 2024

Testing summary:

  1. Nightly GEOSldas tests
    All assim tests fail for run and comparison this is the run error:
    ERROR: cannot find export COND
    All model tests pass.

Here is path for one of the fails: /discover/nobackup/borescan/SystemTests/runs/LDAS_GLOBALCS/assim/CURRENT/scratch/GEOSldas_log_txt

UPDATED by @gmao-rreichle on 6 Aug 2024, 15:42h: After latest commits, GEOSldas tests pass.

  1. 1 day AGCM AMIP, REPLAY and zero-increment REPLAY are all zero diff for data but metadata will make comparison fail due to the long name change.
    See more details below:
    Comparing NC4 catch_internal_checkpoint using nccmp... Failure! Checking for data differences Checking for metadata differences DIFFER : LENGTHS : ATTRIBUTE : long_name : VARIABLE : CDCR2 : 42 <> 46 : VALUES : "max_soil_water_content_above_wilting_point" : "maximum_soil_water_content_above_wilting_point" DIFFER : LENGTHS : ATTRIBUTE : long_name : VARIABLE : WPWET : 24 <> 48 : VALUES : "wetness_at_wilting_point" : "soil_wilting_point_in_degree_of_saturation_units"

  2. regression on branch has passed

@gmao-rreichle gmao-rreichle marked this pull request as ready for review August 6, 2024 19:43
@gmao-rreichle gmao-rreichle requested review from a team as code owners August 6, 2024 19:43
@biljanaorescanin
Copy link
Contributor

Just a quick comment all GEOSldas nightly tests passed after last commit.

@sdrabenh sdrabenh merged commit f824869 into develop Sep 13, 2024
3 of 5 checks passed
@sdrabenh sdrabenh deleted the feature/qliu/add_land_constants_export branch September 13, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add some land constants as HISTORY export variables
5 participants