-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add land constants as HISTORY export variables #970
Conversation
…GridComp.F90, GEOS_LandGridComp.F90, GEOS_CatchGridComp.F90, catchment.F90)
…OS_CatchGridComp.F90)
Testing summary:
Here is path for one of the fails: /discover/nobackup/borescan/SystemTests/runs/LDAS_GLOBALCS/assim/CURRENT/scratch/GEOSldas_log_txt UPDATED by @gmao-rreichle on 6 Aug 2024, 15:42h: After latest commits, GEOSldas tests pass.
|
Just a quick comment all GEOSldas nightly tests passed after last commit. |
Addresses #968, see for additional documentation.
Related PR: GEOS-ESM/GEOSgcm_App#636
The land constants collection defined in GEOS-ESM/GEOSgcm_App#636 matches the land constants file from MERRA-2 but now generated with MAPL HISTORY and with improved SHORT_NAME and LONG_NAME attributes.
The current file content is ok with @rdkoster and myself.
Zero-diff tests successfully conducted for AGCM and GEOSldas by @biljanaorescanin
Contents of sample land constants file verified by @gmao-qliu
@sdrabenh @biljanaorescanin @elakkraoui @rdkoster