Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M21C exports and LONG_NAMES for land water and energy balances #630

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

gmao-rreichle
Copy link
Contributor

@gmao-rreichle gmao-rreichle commented Jul 23, 2024

As in #621 but for M21C.

A couple of open questions:

  1. I had always thought that the "lnd" uses conservative regridding, but this doesn't seem to be the case:

    lnd_tavg_1hr_glo_L@HIST_IMx@HIST_JM_slv.regrid_method: 'BILINEAR_MONOTONIC' ,

    There is no "regrid_method" in the M-2 HISTORY file, but the MAPL version used in M-2 probably works differently.

  2. Do we know what "deflate" does? Is it a lossless or lossy compression?

    lnd_tavg_1hr_glo_L@HIST_IMx@HIST_JM_slv.deflate: 2 ,

@gmao-rreichle gmao-rreichle added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Jul 23, 2024
@gmao-rreichle gmao-rreichle marked this pull request as ready for review July 23, 2024 20:17
@gmao-rreichle gmao-rreichle requested a review from a team as a code owner July 23, 2024 20:17
@sdrabenh
Copy link
Collaborator

As in #621 but for M21C.

A couple of open questions:

  1. I had always thought that the "lnd" uses conservative regridding, but this doesn't seem to be the case:
    lnd_tavg_1hr_glo_L@HIST_IMx@HIST_JM_slv.regrid_method: 'BILINEAR_MONOTONIC' ,

BILINEAR_MONOTONIC is the default method for most collections. However, this could be changed to any of these regridding options if desired - especially for budget terms.

There is no "regrid_method" in the M-2 HISTORY file, but the MAPL version used in M-2 probably works differently.
2. Do we know what "deflate" does? Is it a lossless or lossy compression?

lnd_tavg_1hr_glo_L@HIST_IMx@HIST_JM_slv.deflate: 2 ,

The deflate attribute specifies lossless compression. On the other hand, setting nbits performs "bit shaving" and would be lossy compression.

@sdrabenh
Copy link
Collaborator

@gmao-rreichle merging based on preliminary results. Will continue testing and make further changes if necessary.

@sdrabenh sdrabenh merged commit 4691e74 into R21C Jul 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants