-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LD_PRELOAD for Coupled Model #341
Conversation
@mathomp4 I thinks both MOM5 and MOM6 need explicit LD_PRELOAD. MOM6 does not care now because it luckily goes first in load list (check |
Hmm. Well, I can add that if you like. Give me a second... |
@yvikhlya Okay, this should now preload both. |
Note: I probably need to generalize this for macOS since it is |
I've pushed my generalized updates. Honestly, I think LD_PRELOAD might be ignored on macOS, not sure as it seemed to work with both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work for MOM6.
I have no working restarts at 1-deg
for MOM5, but by the history of this issue and given the lines of changes, I am confident that it will work for MOM5 as well.
For the record, this PR
fixes: GEOS-ESM/GEOSgcm#430
and
resolves: GEOS-ESM/GEOSgcm#352
Recent testing with mom5 by @yvikhlya and @sanAkel (see GEOS-ESM/GEOSgcm#352 and GEOS-ESM/GEOSgcm#430) in GEOSgcm has shown a need to bring back the old
LD_PRELOAD
mechanism that was removed in #204. So this PR brings backLD_PRELOAD
but only in the case of MOM5Obviously not ideal, but until this oddity can be examined by @tclune and @weiyuan-jiang (and maybe @atrayano),
we bring backLD_PRELOAD
ONLY when running MOM5 as runs of MOM6 don't seem to care!As @yvikhlya pointed out below, MOM6 might only work due to luck. So we preload both.