Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to MAPL 2.23.0, ESMA_env v4.2.0, ESMA_cmake v3.17.0 #428

Merged
merged 3 commits into from
Jul 8, 2022

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Jul 5, 2022

This PR updates MAPL to 2.23.0. This REQUIRES using ESMA_env v4.2.0 (aka Baselibs 7.5.0) due to a need for a newer yaFyaml library version. This allows for better error handling in ExtData2G. This is a zero-diff update as nothing has really changed in MAPL, save for needing a new library.

This PR also updates GEOS to use:

  1. ESMA_env v4.2.0
  • Moves to use Baselibs 7.5.0 (needed by MAPL 2.23.0)
  1. ESMA_cmake v3.17.0
  • Updates for Apple Silicon support
  • Change to GNU Release flags

NOTE: That for GNU Release runs of GEOS, this will be non-zero-diff. The change was to better support GCC 12. But this is zero-diff for Intel Fortran.

@mathomp4 mathomp4 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Jul 5, 2022
@mathomp4 mathomp4 self-assigned this Jul 5, 2022
@mathomp4
Copy link
Member Author

mathomp4 commented Jul 5, 2022

CC @bena-nasa @sdrabenh as I test this.

@mathomp4 mathomp4 marked this pull request as ready for review July 6, 2022 12:17
@mathomp4 mathomp4 requested review from a team as code owners July 6, 2022 12:17
@mathomp4 mathomp4 marked this pull request as draft July 6, 2022 12:18
@mathomp4
Copy link
Member Author

mathomp4 commented Jul 6, 2022

Whoops. Undrafted prematurely! (aka I was on the wrong tab 😄 )

@mathomp4 mathomp4 changed the title WIP: Update to MAPL 2.23.0 Update to MAPL 2.23.0 Jul 6, 2022
@mathomp4 mathomp4 marked this pull request as ready for review July 6, 2022 13:55
@mathomp4
Copy link
Member Author

mathomp4 commented Jul 6, 2022

Undrafted. This should be good for testing!

@mathomp4 mathomp4 mentioned this pull request Jul 6, 2022
@mathomp4 mathomp4 changed the title Update to MAPL 2.23.0 Update to MAPL 2.23.0, ESMA_env v4.2.0, ESMA_cmake v3.17.0 Jul 6, 2022
@mathomp4 mathomp4 added the Non 0-diff The changes in this pull request are non-zero-diff label Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. Non 0-diff The changes in this pull request are non-zero-diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants