Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: fixed a bug incorrectly computing FRZMLT #86

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

zhaobin74
Copy link
Contributor

@zhaobin74 zhaobin74 commented Feb 14, 2025

This PR fixed the bug of computing FRZMLT. This is on top of V2. There is a corresponding PR for V3.

It is non 0-diff for MOM6 coupled model.

@zhaobin74 zhaobin74 requested a review from a team as a code owner February 14, 2025 15:25
Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found:

Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: bugfix

1 similar comment
Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: bugfix

@zhaobin74 zhaobin74 added the Non 0-diff The changes in this pull request are non-zero-diff label Feb 14, 2025
@zhaobin74 zhaobin74 changed the title fixed a bug computing FRZMLT for V2 V2: fixed a bug computing FRZMLT Feb 14, 2025
@zhaobin74 zhaobin74 changed the title V2: fixed a bug computing FRZMLT v2: fixed a bug computing FRZMLT Feb 14, 2025
@zhaobin74 zhaobin74 changed the title v2: fixed a bug computing FRZMLT v2: fixed a bug incrrectly computing FRZMLT Feb 14, 2025
@zhaobin74 zhaobin74 changed the title v2: fixed a bug incrrectly computing FRZMLT v2: fixed a bug incorrectly computing FRZMLT Feb 14, 2025
@mathomp4
Copy link
Member

Re-running the CI tests...it should compile.

@sinakhani sinakhani merged commit 1c8c762 into release/v2 Feb 25, 2025
9 checks passed
@sinakhani sinakhani deleted the bugfix/zhaobin74/fixing-computation-frzmlt-v2 branch February 25, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes bugs Non 0-diff The changes in this pull request are non-zero-diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants