Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3: Support for MOM6 as of 2025-Jan-13 #84

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Jan 27, 2025

This PR has CMake updates needed to support mom-ocean/MOM6#1647https://github.com/GEOS-ESM/MOM6/releases/tag/geos%2Fv3.4

Testing shows it is zero-diff.

@mathomp4 mathomp4 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Jan 27, 2025
@mathomp4 mathomp4 self-assigned this Jan 27, 2025
@mathomp4 mathomp4 changed the title v3: Support for MOM6 as of 2024-Nov-27 v3: Support for MOM6 as of 2025-Jan-13 Jan 27, 2025
@mathomp4
Copy link
Member Author

mathomp4 commented Jan 31, 2025

NOTE: CI will fail due to order-of-operations. My CI stack isn't smart enough for a complex PR like this on V12 (too many branches to checkout).

But you can see things working here: GEOS-ESM/GEOSgcm#882

@mathomp4 mathomp4 marked this pull request as ready for review February 6, 2025 12:34
@mathomp4 mathomp4 requested review from a team as code owners February 6, 2025 12:34
Fix bad update
@mathomp4 mathomp4 merged commit 1f342ce into develop Feb 21, 2025
2 of 5 checks passed
@mathomp4 mathomp4 deleted the feature/mathomp4/v3-mom-2024Nov27-support branch February 21, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants