Communicate max slice expiration in SA get_version #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client programs have no way to no what the max slice expiration is. Add the max expiration to the slice authority get_version response so that clients can use the information to determine requested slice lifetimes. Use the key '_GENI_MAX_SLICE_EXPIRATION_DAYS' and set the value appropriately with the unit of days from the constant used in the SA.
Handle some PEP 8 errors in slice authority while we're touching the file. Still more to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client programs have no way to no what the max slice expiration is. Add
the max expiration to the slice authority get_version response so that
clients can use the information to determine requested slice lifetimes.
Use the key '_GENI_MAX_SLICE_EXPIRATION_DAYS' and set the value
appropriately with the unit of days from the constant used in the SA.
Fixes #464