Skip to content
This repository has been archived by the owner on Jun 11, 2022. It is now read-only.

Pinning omniauth-auth2 version to 1.3.1 #10

Merged
merged 2 commits into from
Nov 30, 2015
Merged

Conversation

vgarro
Copy link
Contributor

@vgarro vgarro commented Nov 19, 2015

Pinning omniauth-auth2 version to 1.3.1 since 1.4.1 introduces a change that removes callback_url method required for our Auth Workflow

omniauth/omniauth-oauth2#70

[Fixes #108467542]

…ge that removes `callback_url` method required for our Auth Workflow

omniauth/omniauth-oauth2#70

- Pinning in the mean time doorkeeper fixes it (https://github.com/doorkeeper-gem/doorkeeper/issues/7370 )

[Fixes #108467542]
@vgarro vgarro force-pushed the vg/pinning-omniauth-auth2 branch from df0a4c4 to c65f11f Compare November 19, 2015 18:48
@perryqh
Copy link

perryqh commented Nov 19, 2015

👍

@jonnysamps
Copy link
Contributor

👍

@@ -17,7 +17,8 @@ Gem::Specification.new do |gem|
gem.test_files = gem.files.grep(%r{^(test|spec|features)/})
gem.require_paths = ["lib"]

gem.add_dependency('omniauth-oauth2', '~> 1.1')
# Pinning version to 1.3.1 since 1.4.0 removes the `callback_url` mehtod required for our oauth workflow

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*method

@vgarro vgarro force-pushed the vg/pinning-omniauth-auth2 branch from c67b275 to 63460e9 Compare November 20, 2015 15:32
vgarro added a commit that referenced this pull request Nov 30, 2015
Pinning omniauth-auth2 version to 1.3.1
@vgarro vgarro merged commit 9fe57c5 into master Nov 30, 2015
@vgarro vgarro deleted the vg/pinning-omniauth-auth2 branch November 30, 2015 19:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants