Changeset values should honor comparators #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mining what fields have changed
EnricoMi
requested changes
Apr 24, 2024
| .filter(_.nonEmpty) | ||
| .map(columns => | ||
| concat( | ||
| columns | ||
| .map(c => when(left(backticks(c)) <=> right(backticks(c)), array()).otherwise(array(lit(c)))): _* | ||
| .map(entry => when(entry._2.equiv(left(backticks(entry._1)), right(backticks(entry._1))), array()).otherwise(array(lit(entry._1)))): _* |
There was a problem hiding this comment.
I'd prefer naming the tuple elements, rather than using _1 and _2:
Suggested change
| .map(entry => when(entry._2.equiv(left(backticks(entry._1)), right(backticks(entry._1))), array()).otherwise(array(lit(entry._1)))): _* | |
| .map { case (c, cmp) => | |
| when(cmp.equiv(left(backticks(c)), right(backticks(c))), array()).otherwise(array(lit(c))) | |
| }: _* |
| val rs = left.diff(right, changesetOptions, "id") | ||
| assert(rs.where($"diff" === "C").count() == 1, "Only id=3 should differ with the numeric comparator applied") | ||
| val differingRow: Row = rs.where($"diff" === "C").head | ||
| assert(differingRow.getList(1).size() == 1, "Only floatVal differs after considering the comparators so the changeset should be size 1") |
There was a problem hiding this comment.
Rather than testing for the size, can we test for the actual list content here?
|
Snapshot CI issues to be fixed in #1103. |
|
Thanks for raising and fixing this! |
|
Please run |
|
This has been released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is an improvement PR with the goal of adjusting change column behavior so that it honors comparators when determining what fields have "changed".
What this PR does / why we need it:
If fields A and B differ from left to right for row1 then the changeset column produces an array [A, B] for row1.
If you then configure a comparator to equate the values in A, the changset column still produces an array [A, B] instead of the expected array [B]
Acceptance criteria / Notes for the reviewer
This PR alters the behavior and adds a test to verify it.