-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce dashboard config file to be imported fully #227
Conversation
We need to change the reference to develop before merging. |
Nice. Will test! |
a413a20
to
170f60b
Compare
I would leave it like this for the next revision. Please, check if you are happy with the usage comments and the overall procedure for enabling mmWave sensors. Thanks! |
Perfect. This worked beautifully for me:
Here is a video recording of the whole developer experience: https://drive.google.com/file/d/1ove0QfavvicYuUVXiGGKVqg4i7OQtZ0s/view?usp=sharing Awesome! Well done @gnumpi. 👍 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Successfully compiled and flashed to my unit from macbook pro, then used ESPHome Builder to adopt that device and quickly uncomment 1 line to get the LD2450 operational.
Leaving this at "work in progress" because I know we want to change the branch the dashboard code is referencing. |
@gnumpi what do you think about renaming this file |
I changed the reference to use the develop branch. |
I let you decide on that. Actually, I did rename satellite1.yaml to satellite1.dashboard.yaml in between but renamed it back because users can use this file also as an entry point for their changes when building on their local machines and it now contains the information on how to use it. But I am fine with either name. |
Currently the XMOS does not get flashed automatically when building the firmware from the satellite1.yaml. The user is required to uncomment the debug.yaml line and flash via the button in HA as I thought users might want to have full control over it when they are building their own firmware. But the "xmos_fw_version" substitution on the head of the file might let the user assume that it will be flashed automatically. Do you prefer that the XMOS gets flashed automatically also with satellite1.yaml? |
For consistency, I prefer XMOS flashing to behave the same way it does with satellite1.factory.yaml. If this work takes more than 1 hour then let's merge this PR and do that work in another PR. We need to cut the beta firmware. |
Ok, let's leave it as it is for now and create a ticket for including the automatic XMOS flashing in the next revision. |
25a2762
to
f32e09b
Compare
* - BROKEN: Adding optional ld2450 component - This optional component adds LD241050 support to the Sat1 (however, it is currently causing the wake word not to respond). * Add entities for ld2410 to config. Add example code for sensor tuning. * Removed docs-related YAML. Renamed some sensors for uniformity. Small fixes. * mute pcm5122 on startup * volume and mute support for tas2780 * introduce satellite1 dac_proxy component * enable usage of satellite1 dac proxy * set pcm5122 digital volume control to range from -50db to 0dB * fix: don't set new pcm5122-gpio value on i2c read error * dma and ring-buffer size alignment with 16/48kHz * bump ESPHome to 2024.12.1 * bump ESPHome to 2024.12.2 * tas2780 use stereo downmix * Introducing developer.yaml (#220) - adding optional developer.yaml - gives access to tools to UDP stream microphone for quality testing - optionally emit logs to MQTT server - moves optional packages to satellite1.base * Attempting another LD2450 implementation There are now two non-working implementations in ld2450.yaml file. * - BROKEN: Adding optional ld2450 component - This optional component adds LD241050 support to the Sat1 (however, it is currently causing the wake word not to respond). * Attempting another LD2450 implementation There are now two non-working implementations in ld2450.yaml file. * adjusted volume ranges for tas2780 and pcm5122 * further adjust tas2780 volume settings * fusb302b: move irq handler to core 1 * Confirming LD2450 Code Working - PR#222 allowed to confirm this ls2450 code is working. - Added optional ld2450.yaml file to satellite1.base that the customer can comment out. * Immediately check for update when toggling beta switch (#218) - Immediately check for update when toggling beta switch * Suppress error LEDs when two devices wake simultaneously (#217) Previously when two Sat1s hear the wake word and race to respond one of them would show red LEDs. We are now suppressing the error LEDs on the device that came in second place. This matches Nabus user experience. * fusb302b don't retry the cc detection after it has failed (#221) * adjust wifi settings and audio pipeline timings (#225) * dashboard: Import satellite1.yaml by enabling import_full_config (#227) * dashboard imports satellite1.yaml as it is * satellite1.yaml references components and configs externally (develop branch) --------- Co-authored-by: that1guy <[email protected]> --------- Co-authored-by: that1guy <[email protected]> Co-authored-by: root <root@vscode>
closes #226