Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the publishing of the fuel-core 0.25.0 #1840

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

xgreenx
Copy link
Collaborator

@xgreenx xgreenx commented Apr 19, 2024

Fixed the publishing of the fuel-core 0.25.0 by including the wasm32-unknown-unknown target and adapting the build.rs script to work with the published WASM executor.

Before requesting review

  • I have reviewed the code myself

@xgreenx xgreenx requested review from Voxelot and a team April 19, 2024 10:56
@xgreenx xgreenx self-assigned this Apr 19, 2024
Copy link
Member

@Voxelot Voxelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a simple fix, are you able try a cargo publish --dry-run on fuel-core-bin to see if it works?

Copy link
Collaborator Author

@xgreenx xgreenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not possible to dry-run publishing because sub-crates are not published.

@xgreenx xgreenx merged commit a5552c7 into master Apr 19, 2024
33 checks passed
@xgreenx xgreenx deleted the feature/fix-0.25.0-publishing branch April 19, 2024 14:20
@xgreenx xgreenx mentioned this pull request Apr 19, 2024
1 task
xgreenx added a commit that referenced this pull request Apr 19, 2024
## Version v0.25.1

### Fixed

- [#1840](#1840): Fixed the
publishing of the `fuel-core 0.25.0` release.


### Before requesting review
- [x] I have reviewed the code myself

## What's Changed
* Fixed the publishing of the `fuel-core 0.25.0` by @xgreenx in
#1840


**Full Changelog**:
v0.25.0...v0.25.1
crypto523 pushed a commit to crypto523/fuel-core that referenced this pull request Oct 7, 2024
## Version v0.25.1

### Fixed

- [#1840](FuelLabs/fuel-core#1840): Fixed the
publishing of the `fuel-core 0.25.0` release.


### Before requesting review
- [x] I have reviewed the code myself

## What's Changed
* Fixed the publishing of the `fuel-core 0.25.0` by @xgreenx in
FuelLabs/fuel-core#1840


**Full Changelog**:
FuelLabs/fuel-core@v0.25.0...v0.25.1
sui319 added a commit to sui319/fuel-core that referenced this pull request Feb 17, 2025
## Version v0.25.1

### Fixed

- [#1840](FuelLabs/fuel-core#1840): Fixed the
publishing of the `fuel-core 0.25.0` release.


### Before requesting review
- [x] I have reviewed the code myself

## What's Changed
* Fixed the publishing of the `fuel-core 0.25.0` by @xgreenx in
FuelLabs/fuel-core#1840


**Full Changelog**:
FuelLabs/fuel-core@v0.25.0...v0.25.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants