"flow" op code sanity benchmarks #1433
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| use crate::*; | ||
| // use crate::utils::generate_linear_costs; | ||
|
|
||
| pub fn run_contract(_group: &mut BenchmarkGroup<WallTime>) { | ||
| // This breaks the benchmarking | ||
| // for i in generate_linear_costs() { | ||
| // let id = format!("flow/retd_contract opcode {:?}", i); | ||
| // run( | ||
| // &id, | ||
| // group, | ||
| // vec![ | ||
| // op::movi(0x10, i), | ||
| // op::retd(RegId::ONE, 0x10), | ||
| // op::jmpb(RegId::ZERO, 0), | ||
| // ] | ||
| // .to_vec(), | ||
| // vec![], | ||
| // ); | ||
| // } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,171 @@ | ||
| use crate::{ | ||
| utils::generate_linear_costs, | ||
| *, | ||
| }; | ||
| use rand::{ | ||
| rngs::StdRng, | ||
| SeedableRng, | ||
| }; | ||
|
|
||
| // ECK1: Secp251k1 signature recovery | ||
| // ECR1: Secp256r1 signature recovery | ||
| // ED19: edDSA curve25519 verification | ||
| // K256: keccak-256 | ||
| // S256: SHA-2-256 | ||
| pub fn run_crypto(group: &mut BenchmarkGroup<WallTime>) { | ||
| let rng = &mut StdRng::seed_from_u64(2322u64); | ||
|
|
||
| let message = Message::new(b"foo"); | ||
|
|
||
| let eck1_secret = SecretKey::random(rng); | ||
| let eck1_signature = Signature::sign(&eck1_secret, &message); | ||
| run( | ||
| "crypto/eck1 opcode valid", | ||
| group, | ||
| [ | ||
| op::gtf_args(0x20, 0x00, GTFArgs::ScriptData), | ||
| op::addi( | ||
| 0x21, | ||
| 0x20, | ||
| eck1_signature.as_ref().len().try_into().unwrap(), | ||
| ), | ||
| op::movi(0x10, PublicKey::LEN.try_into().unwrap()), | ||
| op::aloc(0x10), | ||
| op::eck1(RegId::HP, 0x20, 0x21), | ||
| op::jmpb(RegId::ZERO, 0), | ||
| ] | ||
| .to_vec(), | ||
| eck1_signature | ||
| .iter() | ||
| .chain(message.iter()) | ||
| .copied() | ||
| .collect(), | ||
| ); | ||
|
|
||
| let wrong_message = Message::new(b"bar"); | ||
|
|
||
| run( | ||
| "crypto/eck1 opcode invalid", | ||
| group, | ||
| [ | ||
| op::gtf_args(0x20, 0x00, GTFArgs::ScriptData), | ||
| op::addi( | ||
| 0x21, | ||
| 0x20, | ||
| eck1_signature.as_ref().len().try_into().unwrap(), | ||
| ), | ||
| op::movi(0x10, PublicKey::LEN.try_into().unwrap()), | ||
| op::aloc(0x10), | ||
| op::eck1(RegId::HP, 0x20, 0x21), | ||
| op::jmpb(RegId::ZERO, 0), | ||
| ] | ||
| .to_vec(), | ||
| eck1_signature | ||
| .iter() | ||
| .chain(wrong_message.iter()) | ||
| .copied() | ||
| .collect(), | ||
| ); | ||
|
|
||
| let message = fuel_core_types::fuel_crypto::Message::new(b"foo"); | ||
| let ecr1_secret = p256::ecdsa::SigningKey::random(&mut rand::thread_rng()); | ||
| let ecr1_signature = secp256r1::sign_prehashed(&ecr1_secret, &message) | ||
| .expect("Failed to sign with secp256r1"); | ||
|
|
||
| run( | ||
| "crypto/ecr1 opcode", | ||
| group, | ||
| [ | ||
| op::gtf_args(0x20, 0x00, GTFArgs::ScriptData), | ||
| op::addi( | ||
| 0x21, | ||
| 0x20, | ||
| ecr1_signature.as_ref().len().try_into().unwrap(), | ||
| ), | ||
| op::movi(0x10, PublicKey::LEN.try_into().unwrap()), | ||
| op::aloc(0x10), | ||
| op::move_(0x11, RegId::HP), | ||
| op::ecr1(0x11, 0x20, 0x21), | ||
| op::jmpb(RegId::ZERO, 0), | ||
| ] | ||
| .to_vec(), | ||
| ecr1_signature | ||
| .as_ref() | ||
| .iter() | ||
| .chain(message.as_ref()) | ||
| .copied() | ||
| .collect(), | ||
| ); | ||
|
|
||
| let message = fuel_core_types::fuel_crypto::Message::new(b"foo"); | ||
| let ed19_keypair = | ||
| ed25519_dalek::Keypair::generate(&mut ed25519_dalek_old_rand::rngs::OsRng {}); | ||
| let ed19_signature = ed19_keypair.sign(&*message); | ||
|
|
||
| run( | ||
| "crypto/ed19 opcode", | ||
| group, | ||
| [ | ||
| op::gtf_args(0x20, 0x00, GTFArgs::ScriptData), | ||
| op::addi( | ||
| 0x21, | ||
| 0x20, | ||
| ed19_keypair.public.as_ref().len().try_into().unwrap(), | ||
| ), | ||
| op::addi( | ||
| 0x22, | ||
| 0x21, | ||
| ed19_signature.as_ref().len().try_into().unwrap(), | ||
| ), | ||
| op::addi(0x22, 0x21, message.as_ref().len().try_into().unwrap()), | ||
| op::movi(0x10, ed25519_dalek::PUBLIC_KEY_LENGTH.try_into().unwrap()), | ||
| op::aloc(0x10), | ||
| op::move_(0x11, RegId::HP), | ||
| op::ed19(0x20, 0x21, 0x22), | ||
| op::jmpb(RegId::ZERO, 0), | ||
| ] | ||
| .to_vec(), | ||
| ed19_keypair | ||
| .public | ||
| .as_ref() | ||
| .iter() | ||
| .chain(ed19_signature.as_ref()) | ||
| .chain(message.as_ref()) | ||
| .copied() | ||
| .collect(), | ||
| ); | ||
|
|
||
| for i in generate_linear_costs() { | ||
|
There was a problem hiding this comment. I understand you didn't create There was a problem hiding this comment. I don't really understand the name--I've been trying to think of a new name. But it's used in a number of or benchmarks for dependent costs. The actual values used aren't particularly important as long as they show a good range between 0 -> a lot. There was a problem hiding this comment. Renaming |
||
| let id = format!("crypto/s256 opcode {:?}", i); | ||
| run( | ||
| &id, | ||
| group, | ||
| [ | ||
| op::movi(0x11, 32), | ||
| op::aloc(0x11), | ||
| op::movi(0x10, i), | ||
| op::s256(RegId::HP, RegId::ZERO, 0x10), | ||
| op::jmpb(RegId::ZERO, 0), | ||
| ] | ||
| .to_vec(), | ||
| vec![], | ||
| ) | ||
| } | ||
|
|
||
| for i in generate_linear_costs() { | ||
| let id = format!("crypto/k256 opcode {:?}", i); | ||
| run( | ||
| &id, | ||
| group, | ||
| [ | ||
| op::movi(0x11, 32), | ||
| op::aloc(0x11), | ||
| op::movi(0x10, i), | ||
| op::k256(RegId::HP, RegId::ZERO, 0x10), | ||
| op::jmpb(RegId::ZERO, 0), | ||
| ] | ||
| .to_vec(), | ||
| vec![], | ||
| ) | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| use crate::*; | ||
|
|
||
| // JMP: Jump | ||
| // JI: Jump immediate | ||
| // JNE: Jump if not equal | ||
| // JNEI: Jump if not equal immediate | ||
| // JNZI: Jump if not zero immediate | ||
| // JMPB: Jump relative backwards | ||
| // JMPF: Jump relative forwards | ||
| // JNZB: Jump if not zero relative backwards | ||
| // JNZF: Jump if not zero relative forwards | ||
| // JNEB: Jump if not equal relative backwards | ||
| // JNEF: Jump if not equal relative forwards | ||
| // RET: Return from context | ||
| pub fn run_flow(group: &mut BenchmarkGroup<WallTime>) { | ||
| run( | ||
| "flow/jmp opcode", | ||
| group, | ||
| vec![op::movi(0x10, 0), op::jmp(0x10)], | ||
| vec![], | ||
| ); | ||
|
|
||
| run( | ||
| "flow/ji opcode", | ||
| group, | ||
| vec![op::ji(0), op::jmpb(RegId::ZERO, 0)], | ||
| vec![], | ||
| ); | ||
|
|
||
| run( | ||
| "flow/jne opcode", | ||
| group, | ||
| vec![ | ||
| op::movi(0x10, 0), | ||
| op::jne(RegId::ZERO, RegId::ONE, 0x10), | ||
| op::jmpb(RegId::ZERO, 0), | ||
| ], | ||
| vec![], | ||
| ); | ||
|
|
||
| run( | ||
| "flow/jnei opcode", | ||
| group, | ||
| vec![ | ||
| op::jnei(RegId::ZERO, RegId::ONE, 0), | ||
| op::jmpb(RegId::ZERO, 0), | ||
| ], | ||
| vec![], | ||
| ); | ||
|
|
||
| run( | ||
| "flow/jnzi opcode", | ||
| group, | ||
| vec![op::jnzi(RegId::ONE, 0), op::jmpb(RegId::ZERO, 0)], | ||
| vec![], | ||
| ); | ||
|
|
||
| // Don't know how to test "returning" op codes | ||
| // run( | ||
| // "flow/ret_script opcode", | ||
| // group, | ||
| // vec![op::ret(RegId::ONE), op::jmpb(RegId::ZERO, 0)].to_vec(), | ||
| // vec![], | ||
| // ); | ||
| // | ||
| // run( | ||
| // "flow/ret_contract opcode", | ||
| // group, | ||
| // vec![op::ret(RegId::ONE), op::jmpb(RegId::ZERO, 0)].to_vec(), | ||
| // vec![], | ||
| // ); | ||
|
Comment on lines
+174
to
+187
There was a problem hiding this comment. Yeah, You can skip it for now, but create an issue to write a benchmark later that: the scenario either calls another contract and returns with a lot of data or runs a lot of transactions with this opcode. There was a problem hiding this comment. I added it as a subtask to the parent issue, like we did with |
||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,7 @@ | ||
| pub mod alu; | ||
|
|
||
| pub mod crypto; | ||
|
|
||
| pub mod flow; | ||
|
|
||
| pub mod contract; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll probably just keep it since we're gonna add it soon anyway.