Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtract Peer Reputation for Request Timeout #1346

Closed
MitchTurner opened this issue Sep 5, 2023 · 0 comments · Fixed by #1574
Closed

Subtract Peer Reputation for Request Timeout #1346

MitchTurner opened this issue Sep 5, 2023 · 0 comments · Fixed by #1574
Assignees

Comments

@MitchTurner
Copy link
Member

MitchTurner commented Sep 5, 2023

Part of:
#943

Blocked on: #1345

Peers should receive a penalty for not responding to requests.

Dentosal added a commit that referenced this issue Feb 5, 2024
Closes #1345. Closes #1346 Closes #1350.

This PR stops discarding request errors from libp2p, and instead returns
them to the sender of the request. Also penalizes peers for sending
invalid responses or for not replying at all.

Making penalty configurable should be a follow-up PR, as there are other
penalties that should be configurable as well

TODO:
- [x] Make timeout configutable: Already seems to be case on master
branch
- [x] Add tests
- [x] Fix current tests that for some reason don't terminate

---------

Co-authored-by: xgreenx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants