-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added variable for timeout handling #525
base: develop
Are you sure you want to change the base?
Conversation
Wouldn't this be a safety issue since a timeout means everything should usually stop to prevent a problem? |
my initial thought was that motors could stay on, but heater not over longer time. There are already some config options to change behaviour in timeout. Just adding the option to be able to change it without making it the default |
📌 This pull request has been marked as stale because it has not had activity in the past 30 days. |
2 similar comments
📌 This pull request has been marked as stale because it has not had activity in the past 30 days. |
📌 This pull request has been marked as stale because it has not had activity in the past 30 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just a small change about the default value to be able to merge :)
@@ -73,6 +73,8 @@ variable_disable_motors_in_end_print: False | |||
## Automatically turn-off heaters in the END_PRINT macro | |||
variable_turn_off_heaters_in_end_print: True | |||
|
|||
## Automatically disable motors on timeout | |||
variable_disable_motors_on_timeout: False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the default to True
here? The goal is to align it with the default(1)
from the macro
added variable to prevent calling M84 on timeout.
With the G2Z beta, gantry sag is a potenial issue, especially if toolhead is located near the edges.
with the introduced variable, it is now possible to prevent M84 on timeout.
it was copied based on the already existing end print variables, except that i did not added the heater off due to functional safety concerns.